From owner-cvs-all@FreeBSD.ORG Tue Jun 12 10:03:17 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 39AF916A478; Tue, 12 Jun 2007 10:03:17 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by mx1.freebsd.org (Postfix) with ESMTP id 2E91813C4E7; Tue, 12 Jun 2007 10:03:10 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.14.0/8.14.0) with ESMTP id l5CA1lRR013181 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 12 Jun 2007 06:01:47 -0400 (EDT) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.12.9p2/8.12.9/Submit) id l5CA1J1q084373; Tue, 12 Jun 2007 06:01:19 -0400 (EDT) (envelope-from gallatin) Date: Tue, 12 Jun 2007 06:01:19 -0400 From: Andrew Gallatin To: Andre Oppermann Message-ID: <20070612060118.B84335@grasshopper.cs.duke.edu> References: <200706112008.l5BK8CQ7033543@repoman.freebsd.org> <466DACD6.4040606@errno.com> <466DB2FF.9060300@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <466DB2FF.9060300@freebsd.org>; from andre@FreeBSD.org on Mon, Jun 11, 2007 at 10:39:04PM +0200 X-Operating-System: FreeBSD 4.9-RELEASE-p1 on an i386 Cc: Sam Leffler , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2007 10:03:17 -0000 Andre Oppermann [andre@FreeBSD.org] wrote: > Sam Leffler wrote: > > Andre Oppermann wrote: > >> andre 2007-06-11 20:08:12 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/net if.h Log: > >> Add IFCAP_LRO flag for drivers to announce their TCP Large Receive > >> Offload > >> capabilities. > >> Revision Changes Path > >> 1.108 +1 -0 src/sys/net/if.h > >> http://cvsweb.FreeBSD.org/src/sys/net/if.h.diff?r1=1.107&r2=1.108 > >> > >> > > There are many offload capabilities defined that are not well thought > > out. In particular we do not distinguish between ipv4 and ipv6 for > > things like cksum and tso so there's no way to disable individual > > features. The ability to tweak LRO is clearly needed and clearly belong > > as an ifnet capability but unilateraly deciding this is the wrong approach. > > We do distinguish between TSO4 and TSO6 since from the beginning. > > LRO is not hardware dependent but done in software. However it must > be handled from inside the drivers RX function. Our software > implementation will be IPv4 and IPv6 aware right from the beginning. > > It is not an unilateral decision if other directly affected developers > agree (Drew, Jack). I'm fine with it, as long as it is "OK" for the current in-driver software implementations to not support v6. I believe mxge and cxgb both only supprt v4. Drew