From owner-cvs-src@FreeBSD.ORG Sat Feb 14 16:15:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CDBA616A4CE; Sat, 14 Feb 2004 16:15:44 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA69143D1F; Sat, 14 Feb 2004 16:15:44 -0800 (PST) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i1F0FiGe064926; Sat, 14 Feb 2004 16:15:44 -0800 (PST) (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i1F0Fiu7064925; Sat, 14 Feb 2004 16:15:44 -0800 (PST) (envelope-from truckman) Message-Id: <200402150015.i1F0Fiu7064925@repoman.freebsd.org> From: Don Lewis Date: Sat, 14 Feb 2004 16:15:44 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_2 Subject: cvs commit: src/sys/dev/sound/pcm vchan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Feb 2004 00:15:45 -0000 truckman 2004/02/14 16:15:44 PST FreeBSD src repository Modified files: (Branch: RELENG_5_2) sys/dev/sound/pcm vchan.c Log: Partial MFC of revision 1.16. Change KASSERT() in feed_vchan16() into an explicit test and call to panic() so that the buffer overflow just beyond this point is always caught, even when the code is not compiled with INVARIANTS. This will cause a deterministic panic if a particular combination of sound hardware and client software triggers the buffer overflow in the vchan code. This is better than letting the system panic in some unrelated part of the kernel because of heap corruption. Revision Changes Path 1.13.2.1 +3 -1 src/sys/dev/sound/pcm/vchan.c