From owner-freebsd-ports-bugs@freebsd.org Sun Aug 21 15:31:31 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05DC4BC096D for ; Sun, 21 Aug 2016 15:31:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E09BE12C0 for ; Sun, 21 Aug 2016 15:31:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u7LFVUMA096205 for ; Sun, 21 Aug 2016 15:31:30 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 209742] devel/godot: Update to 2.1; add devel/godot-tools port Date: Sun, 21 Aug 2016 15:31:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: lightside@gmx.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Aug 2016 15:31:31 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209742 --- Comment #68 from lightside --- (In reply to comment #67) > GH_TAGNAME_DEMOS kind of defeats the simplicity of GH_TUPLE. > "godotengine" can also be replaced with "${GH_ACCOUNT}" The "Variable GH_ACCOUNT is recursive" in your proposed case. I tried this before. (In reply to comment #67) > GODOTFILE=3D${PKGBASE} would be shorter but I don't understand why you ne= ed > an extra variable. Because PKGBASE has different value: ${PKGNAMEPREFIX}${PORTNAME}${PKGNAMESUFFIX} https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?revision=3D420461&view= =3Dmarkup#l2572 This is just an variable, which not used in port's framework, i.e. to chang= e it in one place, instead of many places, when needed. (In reply to comment #67) > SLAVE_PORT conditionals are almost always an abomination and often can be > replaced with ?=3D variables. This is how it works and proposed by maintainer. Possible to check ${PKGNAMESUFFIX:M-tools} or ${PKGBASE:Mgodot-tools} directly. (In reply to comment #67) > This is confusing. Use PORTEXAMPLES when installing EXMAPLES. I think, The DEMOS option is more appropriate here, but this may add new va= lue to OPTIONS_DEFAULT. The EXAMPLES option was more simple to use, I guess. Moreover, the demos files installed into ${DATADIR}/demos, not ${EXAMPLESDI= R}. This is how it is in current (2.0.3) version and how user's paths may be configured already. (In reply to comment #67) > __DragonFly__ inherited __FreeBSD__ audio stack, so it may want the same. The delta ports (for DragonFlyBSD) uses "alias" for devel/godot port: https://svnweb.freebsd.org/ports/head/Mk/Uses/alias.mk?revision=3D391257&vi= ew=3Dmarkup https://github.com/DragonFlyBSD/DeltaPorts/blob/10b54b72b5524f8f4936daf80ae= 5d9a96a537e8c/ports/devel/godot/Makefile.DragonFly https://github.com/DragonFlyBSD/DPorts/blob/6ae8d72bf6afc35d1c487d6b3ce56f5= 6423f149f/devel/godot/Makefile.DragonFly And this is not only place with __FreeBSD__ define: https://github.com/godotengine/godot/search?q=3D__FreeBSD__ (In reply to comment #67) > Maybe replace with #elif defined(KERN_PROC_PATHNAME) which is available on > FreeBSD, DragonFly and NetBSD. I think, this statement is for upstream, where __FreeBSD__ define already u= sed here. See answer about "alias" above. --=20 You are receiving this mail because: You are the assignee for the bug.=