Date: Sun, 21 Aug 2016 15:31:30 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 209742] devel/godot: Update to 2.1; add devel/godot-tools port Message-ID: <bug-209742-13-BH9GBeHZI4@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-209742-13@https.bugs.freebsd.org/bugzilla/> References: <bug-209742-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209742 --- Comment #68 from lightside <lightside@gmx.com> --- (In reply to comment #67) > GH_TAGNAME_DEMOS kind of defeats the simplicity of GH_TUPLE. > "godotengine" can also be replaced with "${GH_ACCOUNT}" The "Variable GH_ACCOUNT is recursive" in your proposed case. I tried this before. (In reply to comment #67) > GODOTFILE=3D${PKGBASE} would be shorter but I don't understand why you ne= ed > an extra variable. Because PKGBASE has different value: ${PKGNAMEPREFIX}${PORTNAME}${PKGNAMESUFFIX} https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?revision=3D420461&view= =3Dmarkup#l2572 This is just an variable, which not used in port's framework, i.e. to chang= e it in one place, instead of many places, when needed. (In reply to comment #67) > SLAVE_PORT conditionals are almost always an abomination and often can be > replaced with ?=3D variables. This is how it works and proposed by maintainer. Possible to check ${PKGNAMESUFFIX:M-tools} or ${PKGBASE:Mgodot-tools} directly. (In reply to comment #67) > This is confusing. Use PORTEXAMPLES when installing EXMAPLES. I think, The DEMOS option is more appropriate here, but this may add new va= lue to OPTIONS_DEFAULT. The EXAMPLES option was more simple to use, I guess. Moreover, the demos files installed into ${DATADIR}/demos, not ${EXAMPLESDI= R}. This is how it is in current (2.0.3) version and how user's paths may be configured already. (In reply to comment #67) > __DragonFly__ inherited __FreeBSD__ audio stack, so it may want the same. The delta ports (for DragonFlyBSD) uses "alias" for devel/godot port: https://svnweb.freebsd.org/ports/head/Mk/Uses/alias.mk?revision=3D391257&vi= ew=3Dmarkup https://github.com/DragonFlyBSD/DeltaPorts/blob/10b54b72b5524f8f4936daf80ae= 5d9a96a537e8c/ports/devel/godot/Makefile.DragonFly https://github.com/DragonFlyBSD/DPorts/blob/6ae8d72bf6afc35d1c487d6b3ce56f5= 6423f149f/devel/godot/Makefile.DragonFly And this is not only place with __FreeBSD__ define: https://github.com/godotengine/godot/search?q=3D__FreeBSD__ (In reply to comment #67) > Maybe replace with #elif defined(KERN_PROC_PATHNAME) which is available on > FreeBSD, DragonFly and NetBSD. I think, this statement is for upstream, where __FreeBSD__ define already u= sed here. See answer about "alias" above. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209742-13-BH9GBeHZI4>