From owner-freebsd-bugs@FreeBSD.ORG Tue Jun 24 10:50:05 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 18A9D1065678 for ; Tue, 24 Jun 2008 10:50:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 0882F8FC15 for ; Tue, 24 Jun 2008 10:50:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m5OAo4xI051571 for ; Tue, 24 Jun 2008 10:50:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m5OAo4Yg051570; Tue, 24 Jun 2008 10:50:04 GMT (envelope-from gnats) Date: Tue, 24 Jun 2008 10:50:04 GMT Message-Id: <200806241050.m5OAo4Yg051570@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Jaakko Heinonen Cc: Subject: Re: bin/121512: [sysctl] [patch] sysctl(8) should return 1 if the user is not allowed to change values X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Jaakko Heinonen List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jun 2008 10:50:05 -0000 The following reply was made to PR bin/121512; it has been noted by GNATS. From: Jaakko Heinonen To: bug-followup@FreeBSD.org, romain@blogreen.org Cc: mtm@FreeBSD.org Subject: Re: bin/121512: [sysctl] [patch] sysctl(8) should return 1 if the user is not allowed to change values Date: Tue, 24 Jun 2008 13:46:55 +0300 This bug (bin/121512) was fixed by this change: ----- Forwarded message from Mike Makonnen ----- mtm 2008-06-23 22:06:28 UTC FreeBSD src repository Modified files: etc/rc.d auto_linklocal power_profile sysctl sbin/sysctl sysctl.c Log: SVN rev 179965 on 2008-06-23 22:06:28Z by mtm The sysctl(8) program exits on some errors and only emits warnings on others. In the case where it displayed warnings it would still return succesfully. Modify it so that it returns the number of sysctls that it was not able to set. Make use of this in rc.d to display only *unsuccessfull* attempts to set sysctls. Revision Changes Path 1.6 +4 -1 src/etc/rc.d/auto_linklocal 1.13 +5 -1 src/etc/rc.d/power_profile 1.19 +3 -1 src/etc/rc.d/sysctl 1.89 +5 -2 src/sbin/sysctl/sysctl.c ----- End forwarded message -----