From owner-cvs-all  Fri Sep 28  2:54:27 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 180A737B405; Fri, 28 Sep 2001 02:54:21 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id TAA19979;
	Fri, 28 Sep 2001 19:54:10 +1000
Date: Fri, 28 Sep 2001 19:53:35 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@delplex.bde.org>
To: Julian Elischer <julian@elischer.org>
Cc: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>,
	<obrien@FreeBSD.org>, <cvs-committers@FreeBSD.org>,
	<cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/sys proc.h
In-Reply-To: <Pine.BSF.4.21.0109271716250.65838-100000@InterJet.elischer.org>
Message-ID: <20010928194152.Q52718-100000@delplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, 27 Sep 2001, Julian Elischer wrote:

> Personally I'd like to see something that says like:
>
> "small variations to this rule, for the purpose of aligning
> related fields and increasign readability are accepteble."
>
> and maybe an example
>
> struct foo {
> 	int		foo_a;		/* comment */
> 	struct freddy	foo_b;		/* Comment aligned as above. */
> 	union bigwords	*foo_c;		/* All comments aligned */
> 	unsigned char	foo_chars;	/* to allow the eye to scan them */
> 					/* With overflow also aligned */
> 					/* the same as above. */
> 	struct bigstructures foo_vals[NUMSTRUCTS]; /* sometimes you just */
> 					/* have to bend the rules */
> };

This is a large variation.  The small variation is for the "bigstructures"
lines.

	/*
	 * Avoid verbose names and complicated types.
	 */
	volatile const struct verbosestructtagname
		foo_verbosestructmembername[VERBOSEMANIFESTCONSTANTNAME];

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message