From nobody Wed Jun 25 20:11:32 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bSCdj5PNLz60SjK for ; Wed, 25 Jun 2025 20:11:53 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic302-22.consmr.mail.ne1.yahoo.com (sonic302-22.consmr.mail.ne1.yahoo.com [66.163.186.148]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4bSCdj1x6cz3QpP for ; Wed, 25 Jun 2025 20:11:53 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1750882307; bh=tqzXp4Cz+8Y17+Jiv/kMjor1MY/4JnxB06sNW4ud8WM=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=OF7hJm7AtcPqzxOuK4G7EAe3x7o/ImWsfF8wOTojBavBntwH8XxxiMHimvi0ZNh2KpGF8q8pl5vm0rh/zc+EVaPEZeka8cc7CCO8tcILMsB3sTxZMP2b9RFr3uRo1dGNnSbvByZVja7TUKZCa1sboEZaXweOdRhWSzktUsPHH9C43avnk4qQ8F4OqE5A2Gvt4S2F49goexXW0aNT/9csKVCiOl2OJfWPQOxskdzdQ3PzE5qhWaB0Ux0DdIFWoDjhZeAqlPdjZqo0KrxPKkkCV+UqTwbPy6b9oR5kWrzlVmmw1SBbLXOOCms1FkP2LvZz7xUD2r7PJJnRa43eX//48Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1750882307; bh=C6K3ZkO7gSLA6Y31q3Ft1GUvFtxldIZK+M15BjBKbHZ=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=IMUyQb0uPwTfqLZcCuyHT6oXuyCMPWcgtbm2P1nzokofsOtnQg3P1nK+251vpVC/MZqpOoevsuYA8ukDEFutEzXW3607Ar3StsI5+A8/i7Mtbb9LyP8Ya5oqq+UgbcgGvTtgsCzf9IlZNNps5RKVn24uQ7Jv+yfAGVOwtVql5JN/SiBfxkuytwojsgHWOpI1mauPufkaD40tizVU8E/Ja0paJ5CFm8pSqQbAJMBQsAllvbHftRNedzF5Gn7Pxnit8/SjAXK4f2Eh4+R9jGBmyntAXW/hG1d7flwRORX0RoITsY3k39xmyIJ5ggt7ReQNf0dRVCVNFmqFrNpphEN2Bw== X-YMail-OSG: zy42DswVM1l9i5Nsdz1x2L4FYcEpn2iVwbAVHCudrAVqKbkmh1CLvdtKpLaQ78t ToRHVdI9V0QveSlH6TcfedT5K9RJ5hduhnNUNfhMtOQZiagj8ptugmmgOnqWfJlvRnJ3Wh9YOGXz 29cALLWn0N6SFmosVu8KPbH.ksp4w6195f7IZkbmly7WPDnCFGOYiGWiCHHHqDucR2ntjf0jjKIS DuJ88dxqc6paru0k.sw0ZYI26XmP3.VXLn7i4UyO7zEDztnqJTatTrANelVPJ7TLWLmBf6Qdsg5t kBAG9ij1FZTiF4D0MKNpotczJ7cpnyiR2Rny9WvRpIB7AxuLzZMMKatXS7IhF1USB1i62npUhNsx whBHPTqMRVHUTpN2Umu9BmSdq0nbog3dPP5jGvsB.tOdCXJoQ8KweSLqZ554JqvqxSuTN.QjYrFd fSr6uIWxhC3Xb_4ARWuVwCxD5zjpAQljOZeogEqPukuG.Xp9AfzACjRyntq5qEBW9yeZ81hJXsUR lrYbM3toHnxCI_Z_Vno0IMeF2qjjgkIyY_1B.cFFCliKR0Q0pQ18M3NZ1MK7TF5o6E_OoMqIZBZR 4bMvsCCXYhRfGqLa4oREXrTmnj547s2O3Od2qaI7xmAwX1LuLUG1k4xza8MMj2FIFbQ7NXR2HOds DEzrlAcTkBJY4u343Sxi0HOgLdghab30rcoYNfn43gKZRr.VAf_fCte5VoSovUDd_4uPpLhNVP1L jauWZvbLY6MYAKbl9F3RSTHYvtYK9SYLM8QA9ObfnGILMMKUk3VB1CkNk4h.qxHGco8P4AcN6BLL dNDAtgG1MJ5KBjqOzpJL64fBU9ZZi7VPE7ofg2PfBtmeNdMp9rhdgh.cwQhSmboKwwnMKTEl.Nqo rQsLNWi1uo0k55nB2iCgHWTHdp4Y2FtHMlGni7gHIbPrg1VbBesYz.7aQqTxpRRbahHrdty7TxXW pNSbNeFm35.HkaZyBorcCPV._juNu9GMODcxLlq1CBbwKHTxrC4sEewQaMoPKZ2KowRrVUhqrYkV iQ7yqmh_rKMgEQgJVnoy1S1mM2hCgiSnnBIYlW5mi4EU.cQEx82upKm4IwrU6p1I112IRbJ8e38O GhjNzHpzP22C7U5.h3Nc08vBkdBSRf.A7mybAZFsqHE38S8ekhsycquV.EqfcN5.1.NDNq5v413F IUa7bBG6UJd.Ef1bAV2smy1iS0o54J4es8.1wAiwIVqvw2w970hrzm49OFXK98vg1efmQ5BOX6ao Rm77M293F57rEgX92rfLwj_oygs7IXe0masYBPOJwo6jwm6QCqEq0lyc3Cy5O2Wor6Iwebr2pLzr SemT66uxudYft_l8MulfN32A2o1w8.cYv6vxt3d074M4vxcwn6gupPwdk22cNf5_seJew.LG00SY zqJ81Bq_bgxVfDVYsCHQpAPIsnJygll0buAU_p94WSdoYMgYLuCNbOkPrdHfCGvNjw_UkHpAx.et Kcv3K0vT3hvITmBm9MdUW8zj7gmcNz484oMLz.OVgEaU2pTKm9z0aXgurM7M0WHP3uqyV3mql3M3 gcoNfABeaWRhUe0j9tfM5gugg7K4SL.9wj29EebD.Ii1W26B4d18b5lezRvXfHhclPKHNCoyrUVA Kq4xsYVAmPcchfFkOw7FkYaaVGxwBWqRKBYX7fs2ZEp7MLr8hD7HPGcCSFY8Mebvg7i4XGQgoXnN vV605BKcn5rxU5CcyaEM8TJ1FYuqNtBmTqYqyBgb.UAwwZTh0XCdmVB8GCDLlN3K.IRcVPZ3EPVF 7b78FVxPwZdyHnuIFaw7QzbAnhJajRS52411CrWbkwuFcmGEUfOFFRWD_u2cpmlbBOvfzTAvlrgs fqzHlz5leKP_k7nQPZ_VubSYp2XnyCWw4avACfnXZ_cWSD_hJ_c1aWGhwBPBuq7XxNfid3JWMwNF UZpysdB1LKxscrx8TNHG3YphgDu0vmQFMEub7Iy98gIkc8.UOnXCL6iwm8ER1FO141lRgm1BM2zR bDJrVsup_qImgwjPmZsfc96aUL7EWA0eTRd7T29CGpvlvUZpNDtePnwbkzVKN10KDBFkyJsTrf4U fXHd1aLuO5MRVJWhArRgxs1RIAvDaCCoqMlmxM9QEgmzkT7Q5NAGByWvrzF_7Klv2I4FBbLgcW1c vHDCA2gYLFnamDuB6wc4iFbGBO4ZXjh8cKF3ClCwFvnZeQ2VE24Fl4R.WLX2PqkmfOaVgZbjxKK7 zAVzGFdWmt6oTUXfApBasNSCMBsfrZ4rEccmKVD4g5l2Sk57P9tDgMM2dK58g2OhEWdLZvfVqHZ7 n4Dk- X-Sonic-MF: X-Sonic-ID: 831568a9-6ae3-4674-ba4a-adbe77cad299 Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ne1.yahoo.com with HTTP; Wed, 25 Jun 2025 20:11:47 +0000 Received: by hermes--production-gq1-74d64bb7d7-45lk9 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 6622a4da9093430832e7bb43ca5d9820; Wed, 25 Jun 2025 20:11:43 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: git: 288ba78edcfd - main - dev/psci: Check for functions before calling From: Mark Millard In-Reply-To: <3s789nos-rq00-6n4q-46pq-280r4n3q22q6@yvfgf.mnoonqbm.arg> Date: Wed, 25 Jun 2025 13:11:32 -0700 Cc: Andrew Turner , dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <7D17FF6C-DFD8-4921-A50F-B4A196EE86E6@yahoo.com> References: <60E32387-B0BA-4ADD-A897-DC988136D2F9.ref@yahoo.com> <60E32387-B0BA-4ADD-A897-DC988136D2F9@yahoo.com> <3s789nos-rq00-6n4q-46pq-280r4n3q22q6@yvfgf.mnoonqbm.arg> To: "Bjoern A. Zeeb" X-Mailer: Apple Mail (2.3826.600.51.1.1) X-Rspamd-Queue-Id: 4bSCdj1x6cz3QpP X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36646, ipnet:66.163.184.0/21, country:US] On Jun 25, 2025, at 12:48, Bjoern A. Zeeb = wrote: > On Wed, 25 Jun 2025, Mark Millard wrote: >=20 >> Andrew Turner wrote on >> Date: Wed, 25 Jun 2025 11:22:51 UTC : >>=20 >>> The branch main has been updated by andrew: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D288ba78edcfd82b4b558a46fae78e407= 6acbe200 >>>=20 >>> commit 288ba78edcfd82b4b558a46fae78e4076acbe200 >>> Author: Andrew Turner >>> AuthorDate: 2025-06-24 16:47:28 +0000 >>> Commit: Andrew Turner >>> CommitDate: 2025-06-24 17:45:42 +0000 >>>=20 >>> dev/psci: Check for functions before calling >>>=20 >>> In the SMCCC TRNG and Errata ABI drivers check if the version >>> functions are implemented before calling them. Without this the = firmware >>> may complain about an unimplemented function being called. >>>=20 >>> Reported by: bz >>> Reviewed by: bz >>> Sponsored by: Arm Ltd >>> Differential Revision: https://reviews.freebsd.org/D50978 >>> --- >>=20 >>=20 >> I wonder if a debug mode or verbose mode should report >> the !=3D SMCCC_RET_SUCCESS cases for smccc_arch_features. >> If this change had already been in place, the older >> status might not have been noticed. As bz wrote >> elsewhere: >>=20 >> "That said seems like it's still a good idea to add >> these bits to my TF-A." >>=20 >> Having a way to check on if a TF-A instance is too >> old to have a known status for handling things that >> are now requested could be a good thing. >=20 > Please read the comments on the review. If you mean the text: QUOTE If the firmware doesn't implement the Errata ABI then we may enable a workaround in the kernel even if we don't need to, e.g. when the firmware already has a workaround, or the combination of HW means it's not needed END QUOTE Sometimes that might be fine. But other times updating the TF-A may be more appropriate. Thus, sometimes one might want to learn about which workarounds (or no-ops) are being done because the TF-A involved does not claim to even have a feature. Then one can consider what is appropriate for the TF-A, possibly choosing to update it for some of what has workarounds/no-ops in the kernel. So, to some extent my suggestion generalizes beyond the 2 specific messages that you got and the specific changes made for those. It is only a suggestion, possibly not a very valuable one. =3D=3D=3D Mark Millard marklmi at yahoo.com