From owner-freebsd-mips@FreeBSD.ORG  Tue May 19 18:07:34 2015
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: freebsd-mips@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 7C18F51A
 for <freebsd-mips@freebsd.org>; Tue, 19 May 2015 18:07:34 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 60A411FF0
 for <freebsd-mips@freebsd.org>; Tue, 19 May 2015 18:07:34 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t4JI7Yl1018518
 for <freebsd-mips@freebsd.org>; Tue, 19 May 2015 18:07:34 GMT
 (envelope-from daemon-user@phabric-backend.isc.freebsd.org)
Received: (from daemon-user@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t4JI7YdI018517;
 Tue, 19 May 2015 18:07:34 GMT (envelope-from daemon-user)
Date: Tue, 19 May 2015 18:07:34 +0000
To: freebsd-mips@freebsd.org
From: "imp (Warner Losh)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D2585: Avoid trying to build cxbge
 module on MIPS
Message-ID: <b363e4c0b6518fe1bee4c215aac76242@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2585: Avoid trying to build cxbge module on MIPS
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-To: <PHID-USER-mqlw6f5jjiqhbs4co7yd>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-Cc: <PHID-MLST-atmx2bv3tpjmmbxr5xwp>
In-Reply-To: <differential-rev-PHID-DREV-nd4u74hei4ms4b47e3dk-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-nd4u74hei4ms4b47e3dk-req@FreeBSD.org>
Thread-Index: MjE5ZGMwYjE2MTM3YWY0OWUxOWE5YTIyOTBhIFVbe+Y=
Precedence: bulk
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-mips>,
 <mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips/>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
 <mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2015 18:07:34 -0000

imp added a comment.

mipsn32 is a 64-bit ABI too... It has the required function since we have 64-bit atomics...

I suggest losing the (n32)? part of the expression. As for testing it out, well the n32
kernels are a bit of a dog's breakfast at the moment, so who knows...


REVISION DETAIL
  https://reviews.freebsd.org/D2585

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: emaste, np, imp
Cc: freebsd-mips