From owner-cvs-ports@FreeBSD.ORG Thu Jul 16 17:57:09 2009 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E63D10656AB; Thu, 16 Jul 2009 17:57:09 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from mx.egr.msu.edu (surfnturf.egr.msu.edu [35.9.37.164]) by mx1.freebsd.org (Postfix) with ESMTP id 1D9F18FC20; Thu, 16 Jul 2009 17:57:08 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from localhost (localhost [127.0.0.1]) by mx.egr.msu.edu (Postfix) with ESMTP id E3ECA5C198; Thu, 16 Jul 2009 13:40:19 -0400 (EDT) X-Virus-Scanned: amavisd-new at egr.msu.edu Received: from mx.egr.msu.edu ([127.0.0.1]) by localhost (surfnturf.egr.msu.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rBrg+hZ8O3xo; Thu, 16 Jul 2009 13:40:19 -0400 (EDT) Received: from [35.9.44.65] (daemon.egr.msu.edu [35.9.44.65]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: mcdouga9) by mx.egr.msu.edu (Postfix) with ESMTPSA id BB8865C195; Thu, 16 Jul 2009 13:40:19 -0400 (EDT) Message-ID: <4A5F6603.3010401@egr.msu.edu> Date: Thu, 16 Jul 2009 13:40:19 -0400 From: Adam McDougall User-Agent: Thunderbird 2.0.0.22 (X11/20090625) MIME-Version: 1.0 To: Erwin Lansing References: <200907091315.n69DF7jL036835@repoman.freebsd.org> <20090709140850.GZ86673@droso.net> <87iqi2x7st.fsf@kobe.laptop> <20090709143714.GA86673@droso.net> In-Reply-To: <20090709143714.GA86673@droso.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@freebsd.org, Giorgos Keramidas , cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/mail/postfix/files patch-src::util::sys_defs.h X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2009 17:57:09 -0000 Erwin Lansing wrote: > On Thu, Jul 09, 2009 at 05:14:26PM +0300, Giorgos Keramidas wrote: > >> On Thu, 9 Jul 2009 16:08:52 +0200, Erwin Lansing wrote: >> >>> On Thu, Jul 09, 2009 at 01:15:07PM +0000, Giorgos Keramidas wrote: >>> >>>> keramida 2009-07-09 13:15:07 UTC >>>> >>>> FreeBSD ports repository (doc committer) >>>> >>>> Added files: >>>> mail/postfix/files patch-src::util::sys_defs.h >>>> Log: >>>> Patch the src/util/sys_defs.h file of Postfix to fix the build on >>>> FreeBSD-8.0 after the new closefrom() system call was added. >>>> >>>> PR: ports/136459 >>>> Submitted by: Eygene Ryabinkin >>>> Approved by: erwin (portmgr), Sahil Tandon (maintainer) >>>> >>> Well, I just confirmed that the ports tree isn't frozen yet before the >>> 8.0 release, so that doesn't really warrent an approved by line. I >>> didn't actually review the diff, just noted that no explicit approval >>> from portmgr was required. >>> >> I misread the reply then. I thought you had looked at the diff :/ >> >> > No worries, thanks for taking care of this. > > > I think this is now needed on 7-stable as well as of svn 195694 (702104): cc -DDEF_CONFIG_DIR=\"/usr/local/etc/postfix\" -DDEF_DAEMON_DIR=\"/usr/local/libexec/postfix\" -DDEF_COMMAND_DIR=\"/usr/local/sbin\" -DDEF_SENDMAIL_PATH=\"/usr/local/sbin/sendmail\" -DDEF_NEWALIAS_PATH=\"/usr/local/bin/newaliases\" -DDEF_MAILQ_PATH=\"/usr/local/bin/mailq\" -DDEF_MANPAGE_DIR=\"/usr/local/man\" -DDEF_README_DIR=\"/usr/local/share/doc/postfix\" -DDEF_HTML_DIR=\"/usr/local/share/doc/postfix\" -DDEF_QUEUE_DIR=\"/var/spool/postfix\" -DDEF_DATA_DIR=\"/var/db/postfix\" -DDEF_MAIL_OWNER=\"postfix\" -DDEF_SGID_GROUP=\"maildrop\" -DHAS_PCRE -I/usr/local/include -O2 -fno-strict-aliasing -pipe -I. -DFREEBSD7 -c attr_clnt.c In file included from attr_clnt.c:77: /usr/include/unistd.h:329: error: conflicting types for 'closefrom' ./sys_defs.h:1404: error: previous declaration of 'closefrom' was here *** Error code 1 Stop in /var/tmp/ports/usr/ports/mail/postfix/work/postfix-2.6.2/src/util. *** Error code 1 Thanks