From nobody Fri Dec 26 14:49:36 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dd7n95gCwz6LhRF for ; Fri, 26 Dec 2025 14:49:49 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dd7n958KSz3t7t for ; Fri, 26 Dec 2025 14:49:49 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766760589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sNrYBCEnBy9zLdLMgPOyA6pM1Wg+rw/EsYjvz0AmDMQ=; b=gz7ulxQ3EIGj2tDe1UMxdHTWKadURGd1uQri+x9Fcs7pqqy6UWXheORGmkRGQDv2Zd0E0T 9vcxUtdqQcmJm0PKSqaJS+A4QSU6NlwZEBGghDo74XFEeOi41SRfL7zfR4l78txXohFTWv nImEmTM3sFxFNyxKZk0VtS2Q82wza1Pi1oT/UNJKwtCymNud72E4Uwy8oyfiqMHtiske4X yg5xhGwQibk2p+eMAoYVtYWiAhYDcAnQj7iE0nL6tbOxw4HBbEL4pblRg5yQEvbOv9Ger1 0/bHlPGdTKWNIfBTVG+4UqrX6A+qlvbAbInajakchqTGAUemfqEi8bkEgI8s+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766760589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sNrYBCEnBy9zLdLMgPOyA6pM1Wg+rw/EsYjvz0AmDMQ=; b=YR1029nUbkt2Aic3T0IKGI9VC+Afj/PQbPM2s6iJVRNWWBzZmFc2DywLlwuPZKDWh7Ipzr l603XuCd/W9D/ohzjZ8c85O5NFGe9chYdu3QFcTdi/hlbeOT/Yuoy4fcobZdUvIa4t56KN U5TZBGYc+w3gMDBMmVQt2rEX6nPNcN0SXCEunL+9f7jtrkMY6+1sj99TM5c6ARUWREPD/C tFQWntrlYzTBWJ80FuBNCY9txztxJQOV6CWYJVoQ1FNC9b8yURoQseENzLN/r//Q4faFXN GgHaHzMnzwurflwNCbjSV0UtfJL3JhZf/skb7I37ZPhRzw0b4hmcV5PNC69hYQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1766760589; a=rsa-sha256; cv=none; b=n+udBl8Ces52XoGeMKz0N/C0f6iopXUjYyPVVnm1BMCIhrtnkuxYC9l1DZ1eCMBGHzR0Zf awnwfQ4o1+3Ro0CnWNIdiFZVPCkcMdZ9cURQIEB142zeB4FNfMvaJFdtSl10keHs3bdxB4 /CU6gNSDtVgjTQdgzXwmXFV6BN9CuyybtgIDkhIIZ9tYRt9KzuhNgnb19S62yZBxpfvMLV 7F37fLy6tnEP0e7u88NXKXtpoMV3O7lg9he3feFLxmrueJxyqW4a+B/AMkGCVO7wpiKogK HRkUxDgI6481RmekA4zkeWgPqrh4F4q88X9OBkup4X9gzCjfA7GgPhjisJod8A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4dd7n94B81z20X for ; Fri, 26 Dec 2025 14:49:49 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-4ee28771052so10754171cf.1 for ; Fri, 26 Dec 2025 06:49:49 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCW8EcAB91maTJZRUXGmFsAbN4IzHBlt0b3DFL5Z1U35lt8fsPF9G1bA+DsG9u62mghlrH9yvTBXjlgyHcu1p8Xsl57P@freebsd.org X-Gm-Message-State: AOJu0Yz1Gy1LrNVtgtLGQgR/XsO9SLn05UGFnmbxotx/voYHZVrOPKRP 1v+7qoTpb0eD5VF1Fj4M66w45Rn5T932CspH1pZEVHHWkH9nm2ZFvX+EDQBf0GY/lgluMcCbkX9 jI2xRg3sNu1quFsbYmzL4jxjuSzd9U4s= X-Google-Smtp-Source: AGHT+IGPeuEvw7OsptB2WriimpjBc4EiExZH1q4tEqTEHO6rrH3ujq8UuMVWQbd+pNkAAvqkmssE0y9+bf/TsOPMEoA= X-Received: by 2002:ac8:7c49:0:b0:4ed:b409:ca27 with SMTP id d75a77b69052e-4f4abde36bemr250832201cf.10.1766760588647; Fri, 26 Dec 2025 06:49:48 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <694e9c7d.3cfe6.7a265e1e@gitrepo.freebsd.org> In-Reply-To: <694e9c7d.3cfe6.7a265e1e@gitrepo.freebsd.org> From: Nuno Teixeira Date: Fri, 26 Dec 2025 14:49:36 +0000 X-Gmail-Original-Message-ID: X-Gm-Features: AQt7F2qolrvoDP_lFGHpWTFhFfcN09pXHodSQbymIhTHmA04-ZtgVcUoS5lnN98 Message-ID: Subject: Re: git: e2c93ed09f25 - main - sys/font.h: avoid warnings about too-long initializer strings To: Dimitry Andric Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000004a20fd0646dc01a2" --0000000000004a20fd0646dc01a2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Dimitry, I've just spoted by luck that world fails at this commit: Building /usr/obj/usr/src/amd64.amd64/tmp/obj-tools/usr.sbin/zic/_debuginstall In file included from /usr/src/usr.bin/vtfontcvt/vtfontcvt.c:32: /usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/include/sys/font.h:111:22: error: expected ';' at end of declaration list 111 | uint8_t fh_magic[8] __nonstring; | ^ | ; Cheers, Dimitry Andric escreveu (sexta, 26/12/2025 =C3=A0(s) 14:3= 2): > The branch main has been updated by dim: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3De2c93ed09f259ed049923bdaa9b697b= 3586e2f1a > > commit e2c93ed09f259ed049923bdaa9b697b3586e2f1a > Author: Dimitry Andric > AuthorDate: 2025-12-26 14:31:43 +0000 > Commit: Dimitry Andric > CommitDate: 2025-12-26 14:32:09 +0000 > > sys/font.h: avoid warnings about too-long initializer strings > > Mark `font_header::fh_magic` as `__non_string`, to avoid a warning fr= om > clang 21 similar to: > > /usr/src/usr.bin/vtfontcvt/vtfontcvt.c:763:15: error: > initializer-string for character array is too long, array size is 8 but > initializer has size 9 (including the null terminating character); did yo= u > mean to use the 'nonstring' attribute? > [-Werror,-Wunterminated-string-initialization] > 763 | .fh_magic =3D FONT_HEADER_MAGIC, > | ^~~~~~~~~~~~~~~~~ > /usr/obj/usr/src/amd64.amd64/tmp/usr/include/sys/font.h:109:27: > note: expanded from macro 'FONT_HEADER_MAGIC' > 109 | #define FONT_HEADER_MAGIC "VFNT0002" > | ^~~~~~~~~~ > > MFC after: 3 days > --- > sys/sys/font.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/sys/font.h b/sys/sys/font.h > index fb5fbbc9e557..d486dbc3a011 100644 > --- a/sys/sys/font.h > +++ b/sys/sys/font.h > @@ -108,7 +108,7 @@ typedef STAILQ_HEAD(font_list, fontlist) font_list_t; > > #define FONT_HEADER_MAGIC "VFNT0002" > struct font_header { > - uint8_t fh_magic[8]; > + uint8_t fh_magic[8] __nonstring; > uint8_t fh_width; > uint8_t fh_height; > uint16_t fh_pad; > > --=20 Nuno Teixeira FreeBSD UNIX: Web: https://FreeBSD.org --0000000000004a20fd0646dc01a2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Dimitry,

I've just spoted by l= uck that world fails at this commit:

Building /usr/obj/usr/src/amd64= .amd64/tmp/obj-tools/usr.sbin/zic/_debuginstall
In file included from /u= sr/src/usr.bin/vtfontcvt/vtfontcvt.c:32:
/usr/obj/usr/src/amd64.amd64/tm= p/legacy/usr/include/sys/font.h:111:22: error: expected ';' at end = of declaration list
=C2=A0 111 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 uint8_t =C2= =A0 =C2=A0 =C2=A0 =C2=A0 fh_magic[8] __nonstring;
=C2=A0 =C2=A0 =C2=A0 |= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^
=C2=A0 =C2=A0 =C2= =A0 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;

Cheers,

Dimitry Andric <dim@freebsd.org> escreveu (sexta, 26/12/2025 =C3= =A0(s) 14:32):
T= he branch main has been updated by dim:

URL: https://cgit.= FreeBSD.org/src/commit/?id=3De2c93ed09f259ed049923bdaa9b697b3586e2f1a
commit e2c93ed09f259ed049923bdaa9b697b3586e2f1a
Author:=C2=A0 =C2=A0 =C2=A0Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2025-12-26 14:31:43 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2025-12-26 14:32:09 +0000

=C2=A0 =C2=A0 sys/font.h: avoid warnings about too-long initializer strings=

=C2=A0 =C2=A0 Mark `font_header::fh_magic` as `__non_string`, to avoid a wa= rning from
=C2=A0 =C2=A0 clang 21 similar to:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 /usr/src/usr.bin/vtfontcvt/vtfontcvt.c:763:15: = error: initializer-string for character array is too long, array size is 8 = but initializer has size 9 (including the null terminating character); did = you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-= string-initialization]
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 763 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0.fh_magic =3D FONT_HEADER_MAGIC,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0^~~~~~~~~~~~~~~~~
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /usr/obj/usr/src/amd64.amd64/tmp/usr/include/sy= s/font.h:109:27: note: expanded from macro 'FONT_HEADER_MAGIC'
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 109 | #define FONT_HEADER_MAGIC=C2=A0 = =C2=A0 =C2=A0 =C2=A0"VFNT0002"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0^~~~~~~~~~

=C2=A0 =C2=A0 MFC after:=C2=A0 =C2=A0 =C2=A0 3 days
---
=C2=A0sys/sys/font.h | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/sys/font.h b/sys/sys/font.h
index fb5fbbc9e557..d486dbc3a011 100644
--- a/sys/sys/font.h
+++ b/sys/sys/font.h
@@ -108,7 +108,7 @@ typedef STAILQ_HEAD(font_list, fontlist) font_list_t;
=C2=A0#define=C2=A0 =C2=A0 =C2=A0 =C2=A0 FONT_HEADER_MAGIC=C2=A0 =C2=A0 =C2= =A0 =C2=A0"VFNT0002"
=C2=A0struct font_header {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0uint8_t=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fh_mag= ic[8];
+=C2=A0 =C2=A0 =C2=A0 =C2=A0uint8_t=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fh_mag= ic[8] __nonstring;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 uint8_t=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fh_wid= th;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 uint8_t=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fh_hei= ght;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 uint16_t=C2=A0 =C2=A0 =C2=A0 =C2=A0 fh_pad;



--
Nuno Teixeira
=
FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 https://Fr= eeBSD.org
--0000000000004a20fd0646dc01a2--