From owner-freebsd-acpi@FreeBSD.ORG  Sat May  8 12:30:31 2004
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A23C516A4CE; Sat,  8 May 2004 12:30:31 -0700 (PDT)
Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 28AE543D49; Sat,  8 May 2004 12:30:31 -0700 (PDT)
	(envelope-from pjd@darkness.comp.waw.pl)
Received: by darkness.comp.waw.pl (Postfix, from userid 1009)
	id 08323ACADB; Sat,  8 May 2004 21:30:29 +0200 (CEST)
Date: Sat, 8 May 2004 21:30:28 +0200
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Nate Lawson <nate@root.org>
Message-ID: <20040508193028.GH24376@darkness.comp.waw.pl>
References: <20040507231846.F52653@root.org>
	<20040508.054429.99235478.imp@bsdimp.com> <20040508113421.R58706@root.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="aUiDxsG/XgXmoT1Q"
Content-Disposition: inline
In-Reply-To: <20040508113421.R58706@root.org>
User-Agent: Mutt/1.4.2i
X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc
X-OS: FreeBSD 5.2.1-RC2 i386
cc: acpi@freebsd.org
cc: arch@freebsd.org
Subject: Re: New ACPI blacklist format
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 08 May 2004 19:30:31 -0000


--aUiDxsG/XgXmoT1Q
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, May 08, 2004 at 11:37:26AM -0700, Nate Lawson wrote:
+> > : struct acpi_table_desc {
+> > :     char        *signature;
+> > :     char        *oem_id;
+> > :     char        *oem_table_id;
+> > :     char        *oem_rev_op;
+> > :     char        *oem_revision;
+> > :     char        *creator_id;
+> > :     char        *creator_rev_op;
+> > :     char        *creator_revision;
+> > : };
+> > :
+> > : struct acpi_blacklist {
+> > :     int         quirk;
+> > :     struct      acpi_table_desc *match;
+> > : };
+> > :
+> > : #define ACPI_BROKEN     0x1
+> > :
+> > : static struct acpi_table_desc Abit_BP6[] =3D {
+> > :     { "FACP", "AWARD", "AWRDACPI", "<=3D", "30302e31", "", "", "" },
+> > : };
[...]
+> [...] What I meant by compacting was to get a variable
+> number of acpi_table_desc elements in a single blacklist entry without
+> defining a separate static.  Something like this:
+>=20
+> static struct acpi_blacklist blacklist[] =3D {
+>     {
+>         .quirk =3D ACPI_BROKEN,
+>         {
+>             { "FACP", ... },
+>             { "DSDT", ... }
+>         }
+>     },
+>     {
+>         .quirk =3D ...
+>     }
+> };
+>=20
+> The compiler didn't allow this.

Because you have to do something like this:

struct acpi_blacklist {
	int	quirk;
	struct	acpi_table_desc match[DEFINED_SIZE];
};

--=20
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd@FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!

--aUiDxsG/XgXmoT1Q
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAnTVUForvXbEpPzQRAoW9AJ9hWdkTTe+soNgPkdyVK/gbe9+ZewCgmWL5
NhfFNRrpUdQUKc8BirDpYlM=
=IdJH
-----END PGP SIGNATURE-----

--aUiDxsG/XgXmoT1Q--