From owner-svn-src-head@FreeBSD.ORG  Wed Aug 11 19:17:24 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4A7E21065672;
	Wed, 11 Aug 2010 19:17:24 +0000 (UTC)
	(envelope-from will@firepipe.net)
Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com
	[74.125.82.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 6CDC38FC1F;
	Wed, 11 Aug 2010 19:17:23 +0000 (UTC)
Received: by wyj26 with SMTP id 26so599280wyj.13
	for <multiple recipients>; Wed, 11 Aug 2010 12:17:22 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.216.182.202 with SMTP id o52mr17109902wem.29.1281552399731; 
	Wed, 11 Aug 2010 11:46:39 -0700 (PDT)
Received: by 10.216.65.137 with HTTP; Wed, 11 Aug 2010 11:46:39 -0700 (PDT)
In-Reply-To: <20100811143430.GB1707@garage.freebsd.pl>
References: <201008110051.o7B0pp10084996@svn.freebsd.org>
	<20100811143430.GB1707@garage.freebsd.pl>
Date: Wed, 11 Aug 2010 12:46:39 -0600
Message-ID: <AANLkTi=-tAreBq3SnHgJ_2nODaxrb5-ChbDPoCVfJ5v0@mail.gmail.com>
From: Will Andrews <will@firepipe.net>
To: Pawel Jakub Dawidek <pjd@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Will Andrews <will@freebsd.org>
Subject: Re: svn commit: r211157 - in head/sys: modules modules/if_carp net 
	netinet netinet6
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Aug 2010 19:17:24 -0000

On Wed, Aug 11, 2010 at 8:34 AM, Pawel Jakub Dawidek <pjd@freebsd.org> wrote:
> Wouldn't it be better to allow unload only if there are no carp(4)
> interfaces? I'd be glad to destroy my carp interfaces before unloading
> the module, but recompiling the kernel to unload it? Not so much.

Well, in theory, if_clone_detach() is supposed to do that, and it's
called during the unload process prior to NULLing the fp's.  But I've
been unable to verify whether that is enough to prevent races.

--Will.