From nobody Thu May 29 20:08:57 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b7crn632wz5xRRL; Thu, 29 May 2025 20:08:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b7crn3klwz3THf; Thu, 29 May 2025 20:08:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748549337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RJJo1cICxQnUiGQR+XXfvmOA1h22psJXLa42F78suk4=; b=oeK6b8B9hSMvhNTmyAXAnuE38g71nsSKTg7KNDaGszcOqi5jjNCpDHWid/xNpfC/aRiGU/ 9XmQlAZ54fjyLwxrM78j0kdPlJn/HOMHXhTg4+7r/2NNVtrLUvYji3/pumOmBciM3ieLH+ vMFVdu4x0i3ikg3R9lraOdDI7aREgz6lVHnYtWxaVCuyZhEg2tSlPhWmklv83/xZn2q+/3 0yhHcaRNMGt2v9erkHtRBXeRSokbyLxMj1TctDaLHsEk1jjohBSWVt2ZxPSZhOBEq6L27c wVRhMSoJ/PPGrK3DfYMNQuxMkfB2LOTC1TmhZC196/Ighf7/qTFvkbvKVHcOtQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1748549337; a=rsa-sha256; cv=none; b=YUfos5wpU7hINQWxcaO12RSqzApt2Ec1aRz1jrJjVmGzTPd1XfAFBSN+5ll7yHGPVctMXd /IQYFcBPq0umd853lgywpZ+93UWf+xgudSLRTRknCSp6m+zPGz5ZwKrmEXlmI4XrbX8aX1 AfmsQQEiWARRKLLe3wdMaJr89SaN7afyTXA0BuAM72sk/L3kHAnEES6cv1JZjZbWEmKw2E m+WQZNK5XWqN/552dpwCAOT7dDiAdqdGRl9+I6IIeHU63gVqjiVLvQt5w9/KIOjEZ3Km86 meptJVxgqorUfTrNJnBAbA04jR3rAW3My3d93k7LbrO3eqmFz/4/LruuyEYgzQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748549337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RJJo1cICxQnUiGQR+XXfvmOA1h22psJXLa42F78suk4=; b=YeAtdwmarRiWfkXwP6eANYNfx1PgHoiDhXOXF5CfPQz9H5gJBqh3uziWwoNKSh+QqgIk5g 8jOWX8EE8b2vGRbfV3YpPYHhmZsMSmkctLgPwqCO/G4nYbxWrwHP9odUinTDy1codAjpni V9pcMr+VkzZYvyKYKxIIKxRFU23Y9D8W7VSlvBIQHJdH2W7psILcDEflDi5VWjSc07oS/O DJOcB4QIVIGVwmKXRjRqYPeXB/DBrVrMGVYILhXmBX6qZlFfBxZ6W3HtqL04a18+OxGrEK YwYZuB7Sj73o1N/WEXXglKVQwLsldLnmadw+KbF3tJbhUGELKydP3V7OqW3lOQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4b7crn3L8Kz5nq; Thu, 29 May 2025 20:08:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54TK8vGn051378; Thu, 29 May 2025 20:08:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54TK8vRI051375; Thu, 29 May 2025 20:08:57 GMT (envelope-from git) Date: Thu, 29 May 2025 20:08:57 GMT Message-Id: <202505292008.54TK8vRI051375@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: d5e5e24179f4 - main - mail: tests: reset signal disposition before testing List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d5e5e24179f4a98efaadea2b3c43006b322d7f15 Auto-Submitted: auto-generated The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=d5e5e24179f4a98efaadea2b3c43006b322d7f15 commit d5e5e24179f4a98efaadea2b3c43006b322d7f15 Author: Kyle Evans AuthorDate: 2025-05-29 20:08:50 +0000 Commit: Kyle Evans CommitDate: 2025-05-29 20:08:50 +0000 mail: tests: reset signal disposition before testing As a good citizen of the OS, mail(1) won't try to catch signals that were ignored when it started and it won't reconfigure its signal mask unless it's going to try and handle a signal. The test should start mail(1) off in a well-known state for the signal that it's trying to test in order to get the behavior that's desired. No functional change, just improves the resilience of the test. Reviewed by: des Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D50599 --- usr.bin/mail/tests/mailx_signal_test.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/usr.bin/mail/tests/mailx_signal_test.c b/usr.bin/mail/tests/mailx_signal_test.c index d4ce1e536935..be03b54fd51e 100644 --- a/usr.bin/mail/tests/mailx_signal_test.c +++ b/usr.bin/mail/tests/mailx_signal_test.c @@ -50,6 +50,17 @@ mailx_signal_test(int signo, bool interactive) atf_tc_fail("failed to fork"); if (pid == 0) { /* child */ + sigset_t set; + + /* + * Ensure mailx(1) will handle SIGINT; i.e., that it's not + * ignored or blocked. + */ + (void)signal(signo, SIG_DFL); + sigemptyset(&set); + sigaddset(&set, signo); + ATF_REQUIRE_INTEQ(0, sigprocmask(SIG_UNBLOCK, &set, NULL)); + dup2(ipd[0], STDIN_FILENO); close(ipd[0]); close(ipd[1]);