From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Feb 20 22:20:15 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D2F1F16A420 for ; Mon, 20 Feb 2006 22:20:15 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A54543D45 for ; Mon, 20 Feb 2006 22:20:05 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k1KMK5XP030725 for ; Mon, 20 Feb 2006 22:20:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k1KMK5Ko030724; Mon, 20 Feb 2006 22:20:05 GMT (envelope-from gnats) Resent-Date: Mon, 20 Feb 2006 22:20:05 GMT Resent-Message-Id: <200602202220.k1KMK5Ko030724@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Christian Hiris" <4711@chello.at> Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 00D4816A420 for ; Mon, 20 Feb 2006 22:11:36 +0000 (GMT) (envelope-from 4711@chello.at) Received: from chello084114137224.1.15.vie.surfer.at (chello084114137224.1.15.vie.surfer.at [84.114.137.224]) by mx1.FreeBSD.org (Postfix) with SMTP id EE8F643D72 for ; Mon, 20 Feb 2006 22:11:27 +0000 (GMT) (envelope-from 4711@chello.at) Received: (qmail 57357 invoked from network); 20 Feb 2006 22:11:26 -0000 Received: from matrix010.matrix.net (192.168.123.10) by pop.matrix.net with SMTP; 20 Feb 2006 22:11:26 -0000 Message-Id: <1140473486.40858@matrix010.matrix.net> Date: Mon, 20 Feb 2006 23:11:26 +0100 From: "Christian Hiris" <4711@chello.at> To: "FreeBSD gnats submit" X-Send-Pr-Version: gtk-send-pr 0.4.7 Cc: Subject: ports/93610: [patch] audio/goobox - fix build with libnotify-0.3.2 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Feb 2006 22:20:15 -0000 >Number: 93610 >Category: ports >Synopsis: [patch] audio/goobox - fix build with libnotify-0.3.2 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Feb 20 22:20:05 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Christian Hiris >Release: FreeBSD 6.1-PRERELEASE i386 >Organization: >Environment: System: FreeBSD 6.1-PRERELEASE #0: Sat Feb 18 11:57:50 CET 2006 pfnu@matrix010.matrix.net:/usr/obj/usr/src/sys/MATRIX010 >Description: audio/goobox-0.9.93 build target fails. >How-To-Repeat: jail003# cd /usr/ports/audio/goobox [...] if cc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I.. -DGOO_PREFIX=\"/usr/X11R6\" -DGOO_SYSCONFDIR=\"/usr/X11R6/etc\" -DGOO_DATADIR=\"/usr/X11R6/share/gnome\" -DGOO_LIBDIR=\"/usr/X11R6/lib\" -DPIXMAPSDIR=\""/usr/X11R6/share/gnome/pixmaps"\" -DGLADEDIR=\""/usr/X11R6/share/gnome/goobox/glade"\" -DGOO_GLADEDIR=\""/usr/X11R6/share/gnome/goobox/glade"\" -D_REENTRANT -DORBIT2=1 -DXTHREADS -DXUSE_MTSAFE_API -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/orbit-2.0 -I/usr/local/include/libbonobo-2.0 -I/usr/local/include/bonobo-activation-2.0 -I/usr/local/include/libart-2.0 -I/usr/local/include/libxml2 -I/usr/local/include -I/usr/X11R6/include/gtk-2.0 -I/usr/X11R6/lib/gtk-2.0/include -I/usr/X11R6/include/pango-1.0 -I/usr/X11R6/include -I/usr/local/include/freetype2 -I/usr/X11R6/include/libgnome-2.0 -I/usr/X11R6/include/gconf/2 -I/usr/X11R6/include/gnome-vfs-2 .0 -I/usr/X11R6/lib/gnome-vfs-2.0/include -I/usr/X11R6/include/libgnomeui-2.0 -I/usr/X11R6/include/libgnomecanvas-2.0 -I/usr/X11R6/include/libbonoboui-2.0 -I/usr/X11R6/include/gnome-keyring-1 -I/usr/X11R6/include/gnome-vfs-module-2.0 -I/usr/X11R6/include/libglade-2.0 -I/usr/X11R6/include/gstreamer-0.8 -DXTHREADS -DXUSE_MTSAFE_API -I/usr/local/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/dbus-1.0 -I/usr/local/include/dbus-1.0/include -I/usr/X11R6/include/gtk-2.0 -I/usr/X11R6/lib/gtk-2.0/include -I/usr/X11R6/include/pango-1.0 -I/usr/X11R6/include -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/X11R6/include -O2 -fno-strict-aliasing -pipe -MT main.o -MD -MP -MF ".deps/main.Tpo" \ -c -o main.o `test -f 'main.c' || echo './'`main.c; \ then mv -f ".deps/main.Tpo" ".deps/main.Po"; \ else rm -f ".deps/main.Tpo"; exit 1; \ fi main.c:50: error: syntax error before '*' token main.c:50: warning: data definition has no type or storage class main.c: In function `system_notify': main.c:560: error: `NotifyIcon' undeclared (first use in this function) main.c:560: error: (Each undeclared identifier is reported only once main.c:560: error: for each function it appears in.) main.c:560: error: `icon' undeclared (first use in this function) main.c:561: error: `NotifyHints' undeclared (first use in this function) main.c:561: error: `hints' undeclared (first use in this function) main.c:578: warning: assignment makes pointer from integer without a cast gmake[4]: *** [main.o] Error 1 gmake[4]: Leaving directory `/usr/wrkdir/usr/ports/audio/goobox/work/goobox-0.9.93/src' gmake[3]: *** [all-recursive] Error 1 gmake[3]: Leaving directory `/usr/wrkdir/usr/ports/audio/goobox/work/goobox-0.9.93/src' gmake[2]: *** [all] Error 2 gmake[2]: Leaving directory `/usr/wrkdir/usr/ports/audio/goobox/work/goobox-0.9.93/src' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/usr/wrkdir/usr/ports/audio/goobox/work/goobox-0.9.93' gmake: *** [all] Error 2 *** Error code 2 Stop in /usr/ports/audio/goobox. *** Error code 1 >Fix: Patch borrowed from Mandriva linux (goobox-0.9.93-libnotify.patch): --- patch-src-main.c begins here --- --- src/main.c.orig Fri Nov 18 21:20:08 2005 +++ src/main.c Mon Feb 20 22:41:55 2006 @@ -47,7 +47,6 @@ #ifdef HAVE_LIBNOTIFY #include -static NotifyHandle *notify_h = NULL; #endif /* HAVE_LIBNOTIFY */ GtkWindow *main_window = NULL; @@ -193,7 +192,7 @@ #ifdef HAVE_LIBNOTIFY if (! notify_init ("goobox")) - g_error ("Cannot initialize notification system."); + g_warning ("Cannot initialize notification system."); #endif /* HAVE_LIBNOTIFY */ goo_stock_init (); @@ -557,27 +556,10 @@ int y) { #ifdef HAVE_LIBNOTIFY - NotifyIcon *icon = notify_icon_new_from_uri("goobox"); - NotifyHints *hints = NULL; - - if ((x >= 0) && (y >= 0)) { - hints = notify_hints_new (); - notify_hints_set_int (hints, "x", x); - notify_hints_set_int (hints, "y", y); - } + if(!notify_is_initted()) + return; + NotifyNotification *n = notify_notification_new (title,msg,"goobox",GTK_WIDGET (main_window)); + notify_notification_show(n, NULL); - notify_h = notify_send_notification (notify_h, - "device", - NOTIFY_URGENCY_NORMAL, - title, - msg, - icon, - TRUE, 0, - hints, // no hints - NULL, // no user data - 0); - - if (icon != NULL) - notify_icon_destroy (icon); #endif /* HAVE_LIBNOTIFY */ } --- patch-src-main.c ends here --- >Release-Note: >Audit-Trail: >Unformatted: