From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Nov 4 11:40:02 2007 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 96B9016A420 for ; Sun, 4 Nov 2007 11:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 773AF13C4B5 for ; Sun, 4 Nov 2007 11:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id lA4Be24w050667 for ; Sun, 4 Nov 2007 11:40:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id lA4Be2Cm050666; Sun, 4 Nov 2007 11:40:02 GMT (envelope-from gnats) Resent-Date: Sun, 4 Nov 2007 11:40:02 GMT Resent-Message-Id: <200711041140.lA4Be2Cm050666@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Rafaël Carré Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1220716A417 for ; Sun, 4 Nov 2007 11:30:44 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 0136913C4AA for ; Sun, 4 Nov 2007 11:30:44 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.1/8.14.1) with ESMTP id lA4BUYCU081239 for ; Sun, 4 Nov 2007 11:30:34 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.1/8.14.1/Submit) id lA4BUYHQ081238; Sun, 4 Nov 2007 11:30:34 GMT (envelope-from nobody) Message-Id: <200711041130.lA4BUYHQ081238@www.freebsd.org> Date: Sun, 4 Nov 2007 11:30:34 GMT From: Rafaël Carré To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/117810: vlc-devel port could be compiled with lua modules X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Nov 2007 11:40:02 -0000 >Number: 117810 >Category: ports >Synopsis: vlc-devel port could be compiled with lua modules >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Nov 04 11:40:02 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Rafaël Carré >Release: RELENG_7 >Organization: >Environment: FreeBSD zod 7.0-BETA1 FreeBSD 7.0-BETA1 #0: Tue Oct 30 23:30:39 CET 2007 root@zod:/usr/obj/usr/src/sys/ZOD i386 >Description: multimedia/vlc-devel port has some problems: 1/ There is no way to force it to build the lua modules 2/ There is configuration options for dead options, that should be removed 3/ The skins2 option says it enables a "GTK+" interface which is not the case >How-To-Repeat: >Fix: attached patch fix all problems Patch attached with submission follows: diff -ur vlc-devel.orig/Makefile vlc-devel/Makefile --- vlc-devel.orig/Makefile 2007-10-30 19:58:27.000000000 +0100 +++ vlc-devel/Makefile 2007-10-30 20:41:09.000000000 +0100 @@ -35,8 +35,6 @@ OPTIONS+= AVAHI "Avahi (Rendezvous/Bonjour (R) ) networking" On OPTIONS+= CACA "Libcaca Console Graphics Support" Off OPTIONS+= ARTS "Enable arts sound support" Off -OPTIONS+= CORBA "Enable a Corba interface via orbit2" Off -OPTIONS+= DAAP "Connect to iTunes(R) music shares" On OPTIONS+= DEBUG "Enable debuging support" Off OPTIONS+= DTS "DTS decoder support, many DVDs use this" On OPTIONS+= ESOUND "Esound Support" Off @@ -44,8 +42,8 @@ OPTIONS+= FAAD "Faad audio decoder (mp4/aac) support" On OPTIONS+= FLAC "Flac audio codec support" On OPTIONS+= HTTPD "Streaming media control via http" On -OPTIONS+= LAME "Lame mp3 audio encoder support" On OPTIONS+= LIVEMEDIA "Support for rstp/rtp/sdp protocols" On +OPTIONS+= LUA "Enable lua scripting" Off OPTIONS+= MAD "Mad mp3 audio decoder support" On OPTIONS+= MATROSKA "Matroska Container Format support" On OPTIONS+= MPEG2 "Mpeg-2 audio/video decoder Support" On @@ -58,7 +56,7 @@ OPTIONS+= SVG "SVG graphics support" Off OPTIONS+= SVGALIB "SVGALIB video output" Off OPTIONS+= SHOUT "Shout2 support" Off -OPTIONS+= SKINS "Enable GTK+ skinsned interface" Off +OPTIONS+= SKINS "Enable winamp skins interface" Off OPTIONS+= SPEEX "Speex voice codec support" On OPTIONS+= THEORA "OGG/Vorbis video codec support" On OPTIONS+= TWOLAME "Twolame mpeg2 audio encoder support" On @@ -240,13 +238,6 @@ --disable-cddax .endif -.if defined(WITH_CORBA) && !defined(WITHOUT_CORBA) -USE_GNOME+= orbit2 -CONFIGURE_ARGS+=--enable-corba -.else -CONFIGURE_ARGS+=--disable-corba -.endif - .if !defined(WITHOUT_DVBPSI) LIB_DEPENDS+= dvbpsi.4:${PORTSDIR}/multimedia/libdvbpsi CONFIGURE_ARGS+=--enable-dvbpsi \ @@ -324,6 +315,15 @@ CONFIGURE_ARGS+=--disable-x264 .endif +.if (defined(WITH_LUA) || exists(${LOCALBASE}/lib/lua51/liblua.a)) && !defined(WITHOUT_LUA) +USE_LUA=5.1+ +WANT_LUA_VER=5.1 +CONFIGURE_ENV= LUA_CFLAGS="-I${LUA_INCDIR}" LUA_LIBS="-L${LUA_LIBDIR}" +CONFIGURE_ARGS+=--enable-lua +.else +CONFIGURE_ARGS+=--disable-lua +.endif + .if (defined(WITH_CACA) || exists(${LOCALBASE}/lib/libcaca.a)) && !defined(WITHOUT_CACA) .if !defined(WITHOUT_AALIB) WITH_AALIB= yes @@ -334,13 +334,6 @@ CONFIGURE_ARGS+=--disable-caca .endif -.if !defined(WITHOUT_DAAP) -LIB_DEPENDS+= opendaap.0:${PORTSDIR}/devel/libopendaap -CONFIGURE_ARGS+=--enable-daap -.else -CONFIGURE_ARGS+=--disable-daap -.endif - .if !defined(WITHOUT_DTS) LIB_DEPENDS+= dca.0:${PORTSDIR}/multimedia/libdca CONFIGURE_ARGS+=--enable-dca @@ -359,15 +352,6 @@ CONFIGURE_ARGS+=--disable-ggi .endif -# Do not use lame if PACKAGE_BUILDING is defined. since -# lame can NOT be packaged. -.if !defined(WITHOUT_LAME) && !defined(PACKAGE_BUILDING) -LIB_DEPENDS+= mp3lame.0:${PORTSDIR}/audio/lame -CONFIGURE_ARGS+=--enable-mp3lame -.else -CONFIGURE_ARGS+=--disable-mp3lame -.endif - .if !defined(WITHOUT_MATROSKA) LIB_DEPENDS+= matroska.0:${PORTSDIR}/multimedia/libmatroska CONFIGURE_ARGS+=--enable-mkv @@ -490,12 +474,6 @@ CONFIGURE_ARGS+=--disable-gnutls .endif -.if !defined(WITHOUT_SLP) -LIB_DEPENDS+= slp.1:${PORTSDIR}/net/openslp -.else -CONFIGURE_ARGS+=--disable-slp -.endif - .if !defined(WITHOUT_SPEEX) LIB_DEPENDS+= speex.1:${PORTSDIR}/audio/speex CONFIGURE_ARGS+=--enable-speex diff -ur vlc-devel.orig/Makefile.inc vlc-devel/Makefile.inc --- vlc-devel.orig/Makefile.inc 2007-10-30 19:58:27.000000000 +0100 +++ vlc-devel/Makefile.inc 2007-10-30 20:40:02.000000000 +0100 @@ -11,14 +11,11 @@ # # Interface Knobs: # -# WITH_CORBA -# Enable a Corba interface via orbit2 -# # WITH_NCURSES=yes # Ncurses (console) interface # # WITH_SKINS -# This Interface supports a skinned gtk2.0 interface +# This Interface supports a skinned interface using winamp 2.x skins # Skins can be found at http://www.videolan.org/vlc/download-skins.html # # WITHOUT_WXGTK=yes @@ -29,9 +26,6 @@ # WITH_ARTS=yes # Arts Support # -# WITHOUT_DAAP=yes -# Enable libopendaap to connect to iTunes(R) music shares. -# # WITHOUT_DTS=yes # DTS decoder Support # useful for many dvds @@ -49,11 +43,6 @@ # WITH_FLAC=yes # Flac Support # - -# WITHOUT_LAME=yes -# Mp3 encoder Support -# ** NOT DEFINED if PACKAGE_BUILDING is defined ** -# # WITHOUT_A52=yes # liba52 audio support # @@ -145,6 +134,9 @@ # # Other Knobs: # +# WITHOUT_LUA=yes +# Lua scripting: image fetching, and html parsing (youtube, dailymotion ...) +# # WITHOUT_AVAHI=yes # Avahi (Rendezvous/Bonjour (R) ) networking # @@ -194,10 +186,6 @@ # WITH_SSL=yes # Enable TLS/SSL Support for web (httpd) interface # -# WITHOUT_SLP=yes -# Disable SLP service discovery support -# * recommended if you want to stream media -# # WITH_OPTIMIZED_CFLAGS=yes # Compile with -O2 -ffast-math -fomit-frame-pointer # >Release-Note: >Audit-Trail: >Unformatted: