From owner-svn-src-head@freebsd.org  Wed Aug  2 12:41:04 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 22E62DD01B5;
 Wed,  2 Aug 2017 12:41:04 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [88.99.82.50])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id DEB506379C;
 Wed,  2 Aug 2017 12:41:03 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2016.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id D1A81260179;
 Wed,  2 Aug 2017 14:41:01 +0200 (CEST)
Subject: Re: svn commit: r321920 - head/sys/sys
From: Hans Petter Selasky <hps@selasky.org>
To: Konstantin Belousov <kib@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201708021014.v72AEHEk061037@repo.freebsd.org>
 <f7a4a90c-f1d8-b381-27fe-3cf76b574a29@selasky.org>
Message-ID: <37abc595-c80e-a8da-04a8-815f42c634de@selasky.org>
Date: Wed, 2 Aug 2017 14:38:50 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <f7a4a90c-f1d8-b381-27fe-3cf76b574a29@selasky.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Aug 2017 12:41:04 -0000

On 08/02/17 14:36, Hans Petter Selasky wrote:
> On 08/02/17 12:14, Konstantin Belousov wrote:
>> +#define    major(x)    ((int)((dev_t)(x) >> 32))    /* major number */
>> +#define    minor(x)    ((int)((x) & 0xffffffff))    /* minor number */
>> +#define    makedev(x, y)    (((dev_t)(x) << 32) | (y))    /* create 
>> dev_t */
> 
> One more comment on this issue:
> 
> I think makedev(x, y) should be declared like this, to avoid issues when 
> "y" is negative:
> 
> #define    makedev(x, y)    (((dev_t)(x) << 32) | (unsigned int)(y))    
> /* create dev_t */
> 
> ???
> 
> --HPS
> 
> 

And you'll probably want a final wrapping dev_t cast aswell. 128-bit 
numbers are not yet there.

#define	makedev(x, y)    ((dev_t)(((dev_t)(x) << 32) | (unsigned 
int)(y)))
 > /* create dev_t */

--HPS