From owner-freebsd-multimedia@FreeBSD.ORG Sun Apr 10 14:46:17 2005 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9CD9116A4CE; Sun, 10 Apr 2005 14:46:17 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id CF7EA43D46; Sun, 10 Apr 2005 14:46:14 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.1/8.13.1) with ESMTP id j3AEnilr002643; Sun, 10 Apr 2005 08:49:45 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <42593B72.7020404@samsco.org> Date: Sun, 10 Apr 2005 08:42:58 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.5) Gecko/20050218 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "David E. Cross" References: <20050410004807.M33800@monica.cs.rpi.edu> In-Reply-To: <20050410004807.M33800@monica.cs.rpi.edu> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org cc: freebsd-multimedia@freebsd.org cc: re@freebsd.org Subject: Re: patch to src/sys/dev/sound/pcm/ac97.c X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Apr 2005 14:46:17 -0000 David E. Cross wrote: > I would like to request the following be added to > src/sys/dev/sound/pcm/ac97.c prior to 5.4-RELEASE (if at all possible) > > *** ac97.c.orig Sun Apr 10 00:49:08 2005 > --- ac97.c Sun Apr 10 00:48:29 2005 > *************** > *** 129,134 **** > --- 129,135 ---- > { 0x41445360, 0x00, 0, "AD1885", 0 }, > { 0x41445361, 0x00, 0, "AD1886", ad1886_patch }, > { 0x41445362, 0x00, 0, "AD1887", 0 }, > + { 0x41445368, 0x00, 0, "AD1888", ad198x_patch }, > { 0x41445363, 0x00, 0, "AD1886A", 0 }, > { 0x41445370, 0x00, 0, "AD1980", ad198x_patch }, > { 0x41445372, 0x00, 0, "AD1981A", 0 }, > > > I can summarize its affects to various classes of people: > > Affects to people without an AD1888 codec: > > None > > Affects to people WITH an AD1888 codec, the system will output to the port > labeled "speaker" instead of microphone. System will work the same in > multiple operating systems. > > If people are currently using their systems with this codec they will need > to swap their output ports. > > I have _not_ checked audio input or line input (basically, I have checked > nothing other than line-out). > > I believe this is an appropriate change, it makes us consistent with > documentation, and other operating systems. Furthermore, this feature > (playing) is the vast majority of sound activities, so if this makes is > right for playback and wrong for recording... playback is more important, > and we can fix recoding in the future without worries of screwing people > again in the future (since we'll be "right" on the playback). > Committed to HEAD, will commit it to RELENG_5 and RELENG_5_4 in a few days. Scott