From owner-freebsd-gecko@freebsd.org Fri Jan 13 12:08:26 2017 Return-Path: Delivered-To: freebsd-gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AACA4CAC998 for ; Fri, 13 Jan 2017 12:08:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 93FFF1D28 for ; Fri, 13 Jan 2017 12:08:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 935EBCAC997; Fri, 13 Jan 2017 12:08:26 +0000 (UTC) Delivered-To: gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9307CCAC996 for ; Fri, 13 Jan 2017 12:08:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 828431D27 for ; Fri, 13 Jan 2017 12:08:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v0DC8Qc8073463 for ; Fri, 13 Jan 2017 12:08:26 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: gecko@FreeBSD.org Subject: [Bug 215867] www/firefox-esr: volume control don't work with SNDIO option Date: Fri, 13 Jan 2017 12:08:26 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gecko@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 12:08:26 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D215867 --- Comment #10 from Jan Beich (mail not working) --- Comment on attachment 178800 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D178800 firefox-esr.diff Can you split into files/patch-bugNNN chunks for easy lookup on bugzilla.mozilla.org for more details or, at least, in which release landed? For example, files/patch-bug1153179 if you only intend to backport the spec= ific one. > -sndio_get_min_latency(cubeb * ctx, cubeb_stream_params params, uint32_t = * latency_ms) > +sndio_get_min_latency(cubeb * ctx, cubeb_stream_params params, uint32_t = * latency_frames) > { > // XXX Not yet implemented. > - *latency_ms =3D 40; > + *latency_frames =3D 2048; libcubeb only changed how latency is calculated in Firefox 50[1]. Do you re= ally need it on 45.x ? If so adjust sio_par.appbufsz like upstream did. Maybe you want sndio fix[2] from Firefox 48 instead. [1] https://github.com/kinetiknz/cubeb/commit/025b515bfed3 (API) https://github.com/kinetiknz/cubeb/commit/098b9f21bf99 (sndio) https://github.com/kinetiknz/cubeb/commit/46584e72bd5d (alsa) https://github.com/kinetiknz/cubeb/commit/645f58ed0094 (pulse) [2] https://github.com/kinetiknz/cubeb/commit/658d7eba38d4 --=20 You are receiving this mail because: You are the assignee for the bug.=