From owner-freebsd-eclipse@FreeBSD.ORG Thu Sep 15 10:12:54 2005 Return-Path: X-Original-To: freebsd-eclipse@freebsd.org Delivered-To: freebsd-eclipse@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A081116A41F for ; Thu, 15 Sep 2005 10:12:54 +0000 (GMT) (envelope-from andreas.kohn@gmail.com) Received: from vs159088.vserver.de (syndrom23.de [62.75.159.88]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0E47143D45 for ; Thu, 15 Sep 2005 10:12:53 +0000 (GMT) (envelope-from andreas.kohn@gmail.com) Received: from klamath ([212.204.44.203]) (authenticated bits=0) by vs159088.vserver.de (8.12.8/8.12.8) with ESMTP id j8FACnqR024384; Thu, 15 Sep 2005 12:12:49 +0200 From: Andreas Kohn To: Panagiotis Astithas In-Reply-To: <4329166F.30106@ebs.gr> References: <4329166F.30106@ebs.gr> Content-Type: multipart/mixed; boundary="=-uqHbR+5JKDGB4I0VjCbm" Date: Thu, 15 Sep 2005 12:12:48 +0200 Message-Id: <1126779168.990.10.camel@klamath.syndrom23.de> Mime-Version: 1.0 X-Mailer: Evolution 2.4.0 FreeBSD GNOME Team Port Cc: "barbara.xxx1975" , freebsd-eclipse Subject: Re: java/eclipse: error building WITH_MOZILLA=mozilla X-BeenThere: freebsd-eclipse@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "FreeBSD users of eclipse EDI, tools, rich client apps & ports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 10:12:54 -0000 --=-uqHbR+5JKDGB4I0VjCbm Content-Type: text/plain Content-Transfer-Encoding: 7bit Hi, On Thu, 2005-09-15 at 09:36 +0300, Panagiotis Astithas wrote: > barbara.xxx1975 wrote: > > port version: > > # $FreeBSD: ports/java/eclipse/Makefile,v 1.38 2005/09/14 14:46:36 nork Exp $ > > > > I keep getting an error if I try to upgrade(from eclipse-3.1_1) or build eclipse with WITH_MOZILLA=mozilla. > > This doesn't happen if I use the WITH_MOZILLA=firefox. > > > > *UPDATE* (this happened while I was writing): > > When I tryed to build eclipse WITH_MOZILLA=mozilla these ports where not installed: > > nspr-4.6_1 > > nss-3.10 > > firefox-1.0.6_5,1 > > I had them installed to try with WITH_MOZILLA=firefox. > > Now it builds also with WITH_MOZILLA=mozilla. > > As eclipse does not run-depends on them, could I safely pkg_delete them? > > Or should I keep them to avoid to install them again on the next eclipse upgrade? > > You are not supposed to ever use WITH_MOZILLA=mozilla. I don't like this at all. WITH_MOZILLA=mozilla is a perfectly valid setting for other mozilla-using ports, and people probably have their preference in /etc/make.conf (I do). Please see attached patch (line numbers may be off, hand-edited). Regards, Andreas -- was macht man eigentlich auf einer linux-gamer lan ? hl server aufsetzen und freuen ? *duck* ^^ --=-uqHbR+5JKDGB4I0VjCbm Content-Disposition: attachment; filename=eclipse-withmozilla.diff Content-Type: text/x-patch; name=eclipse-withmozilla.diff; charset=UTF-8 Content-Transfer-Encoding: 7bit Index: Makefile =================================================================== RCS file: /storage/freebsd/cvs/ports/java/eclipse/Makefile,v retrieving revision 1.36 diff -u -r1.36 Makefile --- Makefile 28 Aug 2005 15:29:49 -0000 1.36 +++ Makefile 15 Sep 2005 10:09:20 -0000 @@ -44,7 +44,7 @@ .else ECLIPSE_WS= gtk .if !defined(WITHOUT_MOZILLA) -.if defined(WITH_MOZILLA) +.if defined(WITH_MOZILLA) && ${WITH_MOZILLA} != "mozilla" BROWSER= ${WITH_MOZILLA} MAKE_MOZILLA= make_mozilla BUILD_DEPENDS+= ${BROWSER}:${PORTSDIR}/www/${BROWSER} --=-uqHbR+5JKDGB4I0VjCbm--