From nobody Fri Oct 11 15:25:02 2024 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XQ9RQ42H3z5Z2Dh for ; Fri, 11 Oct 2024 15:25:06 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XQ9RP31l0z4mrw; Fri, 11 Oct 2024 15:25:05 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=Z2wAVvd3; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::62e as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-20c544d345cso15775905ad.1; Fri, 11 Oct 2024 08:25:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728660304; x=1729265104; darn=freebsd.org; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=SaLWwi57P5QtnFU733fhbgT8ftbQ67/pw0RMTBF9uIA=; b=Z2wAVvd3wUdUivllbgDzQelFZmQhzU5tj85TReEC2lAwg786CsC4yQT3M3AysdUX8V lHK2lVqh1RxKuchA8DGnkUpr8dpyLzBKfPRGG3gcA8ER/PC0Gogdz0f1FZF2K3uvIurj KMvbsH2FKklRxBwBNHDDp4jaWXL9OQUIRNf1ROsFO5sV/YYtDM3M3YM6Mlu//EFZIumr x1to9qyY+BHHXg+CoG6uvouhCTiHgCtvBRC5DqH/cHZHK93Vh1IxZ/dAnGTGgsICLKNj MvewXp+SiQTiqaQFyg4NSuXgBznRgix9ZWV9R4FEE+NePp2yGNlHwQgAXa7u7vhHE/hV ha6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728660304; x=1729265104; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SaLWwi57P5QtnFU733fhbgT8ftbQ67/pw0RMTBF9uIA=; b=B61GN49qjHSfkTyk93fjpK5lX0oMGAUl/MLZryDBpAnbh5W2PZ/SZ+Jvhvntq5oZeF D4CNi++5x5HAQHES5fC9vOj7jKsiWmW0rpP9uaGuWZBLOJrWg8hfUAfHSrLnz2cb703j DjtAJkbmraDT79jo4Yf6C5xK/raS3atzg68B4s1fka1gfjPUiZ/wdC+Utu9SjuBjm9KD Np3LfuAfUCjAL6BkyvfPHD8ggzbLp/AFyTmYKI8/y48Z9BdlysLSBNF/ZyWRsAHKACYw vTgTseY4oORGED4JEHqA+RwC6Iz8yWrOp0IRIJQaT5yWMPIDKuu0OQkNS0Sy0EBLpCzZ ndLA== X-Forwarded-Encrypted: i=1; AJvYcCXWd5x6uC2H/bTgiCowk+jzu/5pbp61iM30m9u4smtYtpDkRE1BLJCq82CbXGZngFb0C3Hiy8/e4Fq9DufRQSI=@freebsd.org X-Gm-Message-State: AOJu0Yxwt9YQN4pDM3hsXdzFZkvIdx/Sc7y38ZRRYTmfslVUS0oih5+h 9bu6WU2XQAodmkCPR8cvpPgWMbelqAM1LGQVKfy2v1CLKj07hfIhyYuwNHmj X-Google-Smtp-Source: AGHT+IE1eRJhgftCiRNW6aFrIXUsCg+1u+r6VNQB8F5IesX5AiP/UFwUu2kRDfr7X/7fN3G8FDWMuQ== X-Received: by 2002:a17:903:1104:b0:20c:5990:897c with SMTP id d9443c01a7336-20c8051483bmr113103925ad.27.1728660304030; Fri, 11 Oct 2024 08:25:04 -0700 (PDT) Received: from smtpclient.apple ([185.153.179.239]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c8c348f41sm24459465ad.289.2024.10.11.08.25.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Oct 2024 08:25:03 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable From: Enji Cooper List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@FreeBSD.org Mime-Version: 1.0 (1.0) Subject: Re: Review D38047 ... and then there was one.... Date: Fri, 11 Oct 2024 08:25:02 -0700 Message-Id: References: <20241007150830.939DC334@slippy.cwsent.com> Cc: Mark Johnston , "David E. Cross" , FreeBSD Hackers In-Reply-To: <20241007150830.939DC334@slippy.cwsent.com> To: Cy Schubert X-Mailer: iPhone Mail (21G93) X-Spamd-Result: default: False [-3.89 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.89)[-0.889]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; MIME_GOOD(-0.10)[text/plain]; TO_DN_ALL(0.00)[]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; FREEMAIL_FROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; APPLE_IOS_MAILER_COMMON(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::62e:from] X-Rspamd-Queue-Id: 4XQ9RP31l0z4mrw X-Spamd-Bar: --- > On Oct 7, 2024, at 08:08, Cy Schubert wrote: > Yes. I was about to suggest this. Plus, any proposed commit log message > must answer the questions why, what and how. With special attention to why= . I have the same feelings as Cy. FWIW, part of the reason why large/complex changes like this languish in my r= eview queues is in part due to reasons like this. Unless I am a SME in the area who is driven to understand what the change ai= ms to achieve, I will not take the time to review large/complex chances. I h= ave a lot of other things in my life which take priority over large code rev= iews. Please break the large change down into a smaller set of changes/reviews to m= ake it easier to review the overall change effectively. Cheers, -Enji=