From owner-freebsd-mobile Mon Jan 28 16: 1:48 2002 Delivered-To: freebsd-mobile@freebsd.org Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by hub.freebsd.org (Postfix) with ESMTP id BBAC437B404 for ; Mon, 28 Jan 2002 16:01:44 -0800 (PST) Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.11.0/8.11.0) id g0T01hx15344; Mon, 28 Jan 2002 16:01:43 -0800 Date: Mon, 28 Jan 2002 16:01:43 -0800 From: Brooks Davis To: Jim Binkley Cc: freebsd-mobile@FreeBSD.ORG Subject: Re: wi0: if_wi.c access point scanning Message-ID: <20020128160143.A14088@Odin.AC.HMC.Edu> References: <200201172216.OAA08863@sirius.cs.pdx.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="G4iJoqBmSsgzjUCe" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200201172216.OAA08863@sirius.cs.pdx.edu>; from jrb@cs.pdx.edu on Thu, Jan 17, 2002 at 02:16:01PM -0800 Sender: owner-freebsd-mobile@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --G4iJoqBmSsgzjUCe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I tried the code late last week and I'm not having any luck with it. I run wicontrol and get the scanning printout and a bunch of dots, but it just fails with EINVAL when the timeout passes. I'm using a Lucent card. Any ideas? A couple comments on the patch. First, I really don't like the way the code returns EINVAL when it's busy. I think I'd prefer EBUSY or EAGAIN though I'm not sure which is correct. Second, the patch isn't very style(9) compliant. Admitidly, the existing code in the driver isn't very compliant either, but I'd prefer to avoid making it worse. Most of the issues are with multi-line comments or with the formatting of control structures. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --G4iJoqBmSsgzjUCe Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE8VeZnXY6L6fI4GtQRAq+jAKC3PSZnVSBhSmCrYh6m+yvcITaApgCgkAeU yshnsgdUmhmvGUPei+NxoQs= =Vzb9 -----END PGP SIGNATURE----- --G4iJoqBmSsgzjUCe-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message