From owner-freebsd-bugs@freebsd.org Mon Mar 1 06:51:17 2021 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 04F0557062F for ; Mon, 1 Mar 2021 06:51:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DprWm6ZRfz3HV3 for ; Mon, 1 Mar 2021 06:51:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id DFDC45703D2; Mon, 1 Mar 2021 06:51:16 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DFA11570696 for ; Mon, 1 Mar 2021 06:51:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DprWm5xdgz3HPZ for ; Mon, 1 Mar 2021 06:51:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id BEECB1F165 for ; Mon, 1 Mar 2021 06:51:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1216pG5Q040198 for ; Mon, 1 Mar 2021 06:51:16 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1216pGjR040197 for bugs@FreeBSD.org; Mon, 1 Mar 2021 06:51:16 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 253915] pchtherm0: Sensor enable failed Date: Mon, 01 Mar 2021 06:51:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: michal@microwave.sk X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2021 06:51:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253915 --- Comment #1 from michal@microwave.sk --- I managed to fix this first issue with this simple patch: # git diff diff --git a/sys/dev/intel/pchtherm.c b/sys/dev/intel/pchtherm.c index 13f0abc54b6..4a9edc2da28 100644 --- a/sys/dev/intel/pchtherm.c +++ b/sys/dev/intel/pchtherm.c @@ -163,7 +163,7 @@ static int pchtherm_attach(device_t dev) bus_write_1(sc->tbar, PCHTHERM_REG_TSEL, PCHTHERM_GEN_ENABLE); sc->enable =3D bus_read_1(sc->tbar, PCHTHERM_REG_TS= EL); - if (!(sc->enable & PCHTHERM_REG_TSEL)){ + if (!(sc->enable & PCHTHERM_GEN_ENABLE)) { device_printf(dev, "Sensor enable failed\n"= ); return 0; } Now pchtherm gets enabled as it should: # dmesg | grep pchtherm pchtherm0: mem 0x383ffff10000-0x383ffff10fff ir= q 18 at device 31.6 on pci1 pchtherm0: Enabling Sensor But reported values are strange: # sysctl dev.pchtherm dev.pchtherm.0.ctt: 130.0C dev.pchtherm.0.talv: -50.0C dev.pchtherm.0.tahv: -50.0C dev.pchtherm.0.temperature: 67.5C dev.pchtherm.0.pch_hot_level: -50.0C dev.pchtherm.0.t2temp: -50.0C dev.pchtherm.0.t1temp: -50.0C dev.pchtherm.0.t0temp: -50.0C dev.pchtherm.0.pmtime: 1 dev.pchtherm.0.pmtemp: -50.0C dev.pchtherm.0.%parent: pci1 dev.pchtherm.0.%pnpinfo: vendor=3D0x8086 device=3D0x8c24 subvendor=3D0x15d9 subdevice=3D0x086d class=3D0x118000 dev.pchtherm.0.%location: slot=3D31 function=3D6 dbsf=3Dpci0:0:31:6 handle=3D\_SB_.PCI0.TERM dev.pchtherm.0.%driver: pchtherm dev.pchtherm.0.%desc: Haswell Thermal Subsystem dev.pchtherm.%parent:=20 regards, michal --=20 You are receiving this mail because: You are the assignee for the bug.=