From owner-cvs-ports@FreeBSD.ORG Fri Jun 13 22:08:11 2008 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37EB01065672 for ; Fri, 13 Jun 2008 22:08:11 +0000 (UTC) (envelope-from saper@system.pl) Received: from system.pl (ns356865.ovh.net [91.121.143.223]) by mx1.freebsd.org (Postfix) with ESMTP id 9F95B8FC15 for ; Fri, 13 Jun 2008 22:08:09 +0000 (UTC) (envelope-from saper@system.pl) Received: (qmail 11442 invoked by uid 10); 14 Jun 2008 00:08:06 +0200 Received: from radziecki.saper.info (localhost [127.0.0.1]) by radziecki.saper.info (8.14.2/8.14.2) with ESMTP id m5DM7TYc010918 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 14 Jun 2008 00:07:32 +0200 (CEST) (envelope-from saper@SYSTEM.PL) Message-ID: <4852EF9E.1020802@SYSTEM.PL> Date: Sat, 14 Jun 2008 00:07:26 +0200 From: Marcin Cieslak User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.8.1.13) Gecko/20080405 SeaMonkey/1.1.9 Mnenhy/0.7.5.0 MIME-Version: 1.0 To: Edwin Groothuis References: <200806131120.m5DBKDIW037834@repoman.freebsd.org> <20080613142924.03e8495a@it.buh.tecnik93.com> <4852ADA0.9010100@SYSTEM.PL> <20080613214419.GA89632@k7.mavetju> In-Reply-To: <20080613214419.GA89632@k7.mavetju> X-Enigmail-Version: 0.95.6 OpenPGP: id=B0636ED9; url=http://saper.info/key Content-Type: multipart/signed; micalg=pgp-ripemd160; protocol="application/pgp-signature"; boundary="------------enig1FC31140A8F096CBD6EC1C71" Cc: cvs-ports@FreeBSD.org, "QA Tindy \(Ion-Mihai Tetcu\)" , Mark Linimon , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/security/fwknop Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jun 2008 22:08:11 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1FC31140A8F096CBD6EC1C71 Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: quoted-printable Edwin Groothuis wrote: > I understand the moving to BUILD_DEPNDS, but I don't understand the > killing of the RUN_DEPENDS. >=20 > I will do it for now, but you might want to rethink it (he said > without any knowledge of Java or the application itself) Well actually we need both. They are required both at the build as well=20 as at the run time. Probably we could introduce something like=20 JAR_DEPENDS=3D for java ports that would be similar in LIB_DEPENDS but=20 depending on .jar files. For now we need both like in jakarta-commons-httpclient/Makefile for=20 example. Something like this should do then: cvs diff: Diffing . Index: Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /usr/home/ncvs/ports/net/tn5250j/Makefile,v retrieving revision 1.1 diff -u -u -r1.1 Makefile --- Makefile 13 Jun 2008 02:37:00 -0000 1.1 +++ Makefile 13 Jun 2008 22:06:49 -0000 @@ -17,9 +17,10 @@ BUILD_DEPENDS=3D ${JAVAJARDIR}/mail.jar:${PORTSDIR}/java/javamail \ ${JYTHON_JAR}:${PORTSDIR}/lang/jython \ - ${JAVAJARDIR}/jt400.jar:${PORTSDIR}/sysutils/jtopen -RUN_DEPENDS=3D ${JAVAJARDIR}/itext.jar:${PORTSDIR}/devel/itext \ + ${JAVAJARDIR}/jt400.jar:${PORTSDIR}/sysutils/jtopen \ + ${JAVAJARDIR}/itext.jar:${PORTSDIR}/devel/itext \ ${JAVAJARDIR}/log4j.jar:${PORTSDIR}/devel/log4j +RUN_DEPENDS=3D ${BUILD_DEPENDS} USE_ZIP=3D yes USE_ANT=3D yes --=20 << Marcin Cieslak // saper@system.pl >> --------------enig1FC31140A8F096CBD6EC1C71 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQCVAwUBSFLvoT2W2v2wY27ZAQNjcgP/ZXwk5hMwkzpXP2ZC0Uxwq7dtBmIH8jNr H6Lr9esC9CRIvuxJym/Ds3Huk7HsyynwXPqyiwr0GLjYMQN5sGZ9khY6dKXnaswo AIZHTsSr3TgvY1pwIyCDa1W1wTtd/sf9Tm2zYJT1PqFMt4ZLWrgsL7v2NiUn55A/ /Dgt8476yQs= =MVbS -----END PGP SIGNATURE----- --------------enig1FC31140A8F096CBD6EC1C71--