From owner-svn-ports-head@FreeBSD.ORG Sun Jul 13 18:17:54 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8411CC11; Sun, 13 Jul 2014 18:17:54 +0000 (UTC) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BF472CF2; Sun, 13 Jul 2014 18:17:54 +0000 (UTC) Received: from [192.168.192.25] (dhcp-108-170-169-12.cable.user.start.ca [108.170.169.12]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by apnoea.adamw.org (Postfix) with ESMTPSA id 128D712B02A; Sun, 13 Jul 2014 14:17:51 -0400 (EDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r361631 - head/multimedia/vlc From: Adam Weinberger In-Reply-To: <20140713201352.62e74754@kalimero.tijl.coosemans.org> Date: Sun, 13 Jul 2014 14:17:50 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <81318D98-E35D-46C9-ABB3-6A2ACA2B2810@adamw.org> References: <201407121803.s6CI3OOe033915@svn.freebsd.org> <40140582-EA6A-4ACB-9A28-93A6647B46B7@adamw.org> <20140713164929.GO93051@ivaldir.etoilebsd.net> <20140713201352.62e74754@kalimero.tijl.coosemans.org> To: Tijl Coosemans X-Mailer: Apple Mail (2.1878.6) Cc: svn-ports-head@freebsd.org, Juergen Lock , Baptiste Daroussin , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jul 2014 18:17:54 -0000 On 13 Jul, 2014, at 14:13, Tijl Coosemans wrote: > On Sun, 13 Jul 2014 12:53:25 -0400 Adam Weinberger wrote: >> On 13 Jul, 2014, at 12:49, Baptiste Daroussin = wrote: >>> On Sun, Jul 13, 2014 at 12:40:38PM -0400, Adam Weinberger wrote: >>>> On 12 Jul, 2014, at 14:03, Juergen Lock wrote: >>>>=20 >>>>> Modified: head/multimedia/vlc/Makefile >>>>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>>>> --- head/multimedia/vlc/Makefile Sat Jul 12 17:58:06 2014 = (r361630) >>>>> +++ head/multimedia/vlc/Makefile Sat Jul 12 18:03:24 2014 = (r361631) >>>>> @@ -198,6 +198,7 @@ MTP_CONFIGURE_ENABLE=3D mtp >>>>>=20 >>>>> MUSEPACK_LIB_DEPENDS=3D libmpcdec.so:${PORTSDIR}/audio/musepack >>>>> MUSEPACK_CONFIGURE_ENABLE=3D mpc >>>>> +MUSEPACK_CONFIGURE_ENV=3D = LIBS_mpc=3D"-L${LOCALBASE}/lib -lmpcdec=94 >>>>=20 >>>> You want MUSEPACK_CONFIGURE_ON here. ${opt}_CONFIGURE_ENV doesn=92t = exist. >>>>=20 >>>> bapt can tell you how many times I=92ve made that mistake... >>>=20 >>> Well ${opt}_CONFIGURE_ENV does exists :) your mistake was another = one I don't >>> remember :) >>=20 >> Oh, crap! That=92s right... it was _CONFIGURE_ARGS that I keep trying = for. I >> give _CONFIGURE_* a 10-foot berth now. >=20 > Now that we have *_OFF we could make CONFIGURE_ARGS the same > as CONFIGURE_ENV by adding support for *_CONFIGURE_ARGS and > *_CONFIGURE_ARGS_OFF (and maybe mark *_CONFIGURE_ON and > *_CONFIGURE_OFF deprecated). I=92d certainly break things less often that way. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org