From owner-cvs-src@FreeBSD.ORG Sat Mar 17 05:10:22 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D3D7216A400 for ; Sat, 17 Mar 2007 05:10:22 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.226]) by mx1.freebsd.org (Postfix) with ESMTP id 8DA9713C487 for ; Sat, 17 Mar 2007 05:10:22 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: by wr-out-0506.google.com with SMTP id 36so788396wra for ; Fri, 16 Mar 2007 22:10:22 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=boNTeH4DExiy/+UGe5EbrtAHv4ZYuUDdVDLAG7nx8kZY3ymeBBF9jCmIlndVYDI7/3BtGnn4439wo2oMTK0HElM67USHLIecyfQ+EBVN0nSkUxtwqSCw/qgZidx/Zk109Z+ukW7IdO5EhOzJ+ZGWsg3fHLCJc2i3L/6xmDf+QMg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=BATBUKkAmjQe9xeUNLhG3A4ERUks9yaOYjep28SjZmKYkcR96hY/59B6maUvKz3Zgw430ZQWhBaTcyT2zPYFhLq+GBcDXZ/YmN8eJ2D05kz6gChUPETjHDxCx5WB8P/WzS1357ReWos9mPu/ew9itXKJDgj2egenhSCOg+IHQwo= Received: by 10.90.65.11 with SMTP id n11mr2597248aga.1174108221975; Fri, 16 Mar 2007 22:10:21 -0700 (PDT) Received: by 10.90.25.1 with HTTP; Fri, 16 Mar 2007 22:10:21 -0700 (PDT) Message-ID: Date: Fri, 16 Mar 2007 22:10:21 -0700 From: "Kip Macy" To: "Andre Oppermann" In-Reply-To: <200703151559.l2FFxSG7088256@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200703151559.l2FFxSG7088256@repoman.freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp.h tcp_input.c tcp_output.c tcp_syncache.c tcp_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Mar 2007 05:10:22 -0000 I get a panic in tcp_syncache when I fire up xemacs over "ssh -Y". -Kip On 3/15/07, Andre Oppermann wrote: > andre 2007-03-15 15:59:28 UTC > > FreeBSD src repository > > Modified files: > sys/netinet tcp.h tcp_input.c tcp_output.c > tcp_syncache.c tcp_var.h > Log: > Consolidate insertion of TCP options into a segment from within tcp_output() > and syncache_respond() into its own generic function tcp_addoptions(). > > tcp_addoptions() is alignment agnostic and does optimal packing in all cases. > > In struct tcpopt rename to_requested_s_scale to just to_wscale. > > Add a comment with quote from RFC1323: "The Window field in a SYN (i.e., > a or ) segment itself is never scaled." > > Reviewed by: silby, mohans, julian > Sponsored by: TCP/IP Optimization Fundraise 2005 > > Revision Changes Path > 1.35 +5 -2 src/sys/netinet/tcp.h > 1.317 +2 -2 src/sys/netinet/tcp_input.c > 1.126 +199 -146 src/sys/netinet/tcp_output.c > 1.105 +43 -75 src/sys/netinet/tcp_syncache.c > 1.140 +14 -8 src/sys/netinet/tcp_var.h >