From owner-svn-src-head@freebsd.org Thu Nov 5 23:35:59 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7ED40A27A90; Thu, 5 Nov 2015 23:35:59 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 6396D1847; Thu, 5 Nov 2015 23:35:59 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 5C2D518D1; Thu, 5 Nov 2015 23:35:59 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 08E0E16476; Thu, 5 Nov 2015 23:35:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id M_q4Q21a0lRl; Thu, 5 Nov 2015 23:35:56 +0000 (UTC) Subject: Re: svn commit: r290428 - head/share/man/man9 DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 1E9211646D To: Ian Lepore , "O'Connor, Daniel" , Adrian Chadd References: <201511052250.tA5MoMOk060206@repo.freebsd.org> <84180B50-DEE2-454F-BD8E-C7F1B97CD301@dons.net.au> <1446766105.91534.407.camel@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <563BE7E2.4020402@FreeBSD.org> Date: Thu, 5 Nov 2015 15:36:02 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446766105.91534.407.camel@freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4gDnCo78qDEc5euttFEHe23GFLqTC54Q3" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Nov 2015 23:35:59 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4gDnCo78qDEc5euttFEHe23GFLqTC54Q3 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 11/5/2015 3:28 PM, Ian Lepore wrote: > On Fri, 2015-11-06 at 09:37 +1030, O'Connor, Daniel wrote: >> Presumably the intent was to have an extra line after the \ so diffs >> are reduced for future additions. >> >=20 > Yeah. I wish we did that pretty much universally wherever lists of > things appear (SRCS and OBJS lists in makefiles, a trailing comma on ar= > ray and enum init lists in C, etc). >=20 Me too. It leads to bugs like this though when an empty line does not follow. We've done this pattern at work but I avoid doing so here. >=20 >>> On 6 Nov 2015, at 09:20, Adrian Chadd wrote: >>> >>> Author: adrian >>> Date: Thu Nov 5 22:50:21 2015 >>> New Revision: 290428 >>> URL: https://svnweb.freebsd.org/changeset/base/290428 >>> >>> Log: >>> remove \, it confuses things. >>> >>> Modified: >>> head/share/man/man9/Makefile >>> >>> Modified: head/share/man/man9/Makefile >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> --- head/share/man/man9/Makefile Thu Nov 5 22:44:36 2015=09 >>> (r290427) >>> +++ head/share/man/man9/Makefile Thu Nov 5 22:50:21 2015=09 >>> (r290428) >>> @@ -1294,7 +1294,7 @@ MLINKS+=3Dpci.9 pci_alloc_msi.9 \ >>> pci.9 pci_write_config.9 \ >>> pci.9 pcie_adjust_config.9 \ >>> pci.9 pcie_read_config.9 \ >>> - pci.9 pcie_write_config.9 \ >>> + pci.9 pcie_write_config.9 >>> MLINKS+=3Dpci_iov_schema.9 pci_iov_schema_alloc_node.9 \ >>> pci_iov_schema.9 pci_iov_schema_add_bool.9 \ >>> pci_iov_schema.9 pci_iov_schema_add_string.9 \ --=20 Regards, Bryan Drewery --4gDnCo78qDEc5euttFEHe23GFLqTC54Q3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWO+fiAAoJEDXXcbtuRpfPiAMH/R1EEsMnFXqT0iGFYhmkJg3Z HvKN4ZBfBqfwQdZXTxT1tLBo2vRFlx3cjfeczp42Nze5tFlc/8WpQLXAiMZ2cgJW 0tLOTgjKwpn4jYMJKVJ/IfebY+aqosxaCy56ynMmxZKB9XyFROfkLwOojlO3AQYl XyWbLkmGhkZasgJJ64OvYdZgaZ/Q6QvTYlxHb8H/yvVMXi/7phuM1DfkXpEJnb/X mWuWKryeVA/mRzjbH4BA8wCWBpt/doQ8XNk/6AFV7lxvOG+PANh/ukrsXQFIUyuS CKIQE+kob1ToehsPvnGQzFAg1pDop0Uhf2IhMjZ8YizoXOrJSLsy4ywWJ4OyBpY= =SRrx -----END PGP SIGNATURE----- --4gDnCo78qDEc5euttFEHe23GFLqTC54Q3--