From owner-svn-src-all@FreeBSD.ORG Wed Jul 3 10:36:42 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B14946AA; Wed, 3 Jul 2013 10:36:42 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id 2B1111C02; Wed, 3 Jul 2013 10:36:42 +0000 (UTC) Received: from alph.d.allbsd.org (p3086-ipbf906funabasi.chiba.ocn.ne.jp [122.26.46.86]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id r63AaOse033466 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 3 Jul 2013 19:36:35 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.5/8.14.5) with ESMTP id r63AaNnU041671; Wed, 3 Jul 2013 19:36:24 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Wed, 03 Jul 2013 18:51:50 +0900 (JST) Message-Id: <20130703.185150.1466238345990988743.hrs@allbsd.org> To: uqs@FreeBSD.org Subject: Re: svn commit: r252408 - head/sbin/ifconfig From: Hiroki Sato In-Reply-To: <20130703092307.GA2294@acme.spoerlein.net> References: <201306300737.r5U7bWkB096070@svn.freebsd.org> <20130703092307.GA2294@acme.spoerlein.net> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Wed_Jul__3_18_51_50_2013_293)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Wed, 03 Jul 2013 19:36:35 +0900 (JST) X-Spam-Status: No, score=-88.9 required=13.0 tests=CONTENT_TYPE_PRESENT, DIRECTOCNDYN,DYN_PBL,MIMEQENC,ONLY1HOPDIRECT,QENCPTR1,QENCPTR2,RCVD_IN_PBL, SAMEHELOBY2HOP,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jul 2013 10:36:42 -0000 ----Security_Multipart(Wed_Jul__3_18_51_50_2013_293)-- Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Ulrich Sp=F6rlein wrote in <20130703092307.GA2294@acme.spoerlein.net>: uq> > if ((s6 =3D socket(AF_INET6, SOCK_DGRAM, 0)) < 0) { uq> > - if (errno !=3D EAFNOSUPPORT) uq> > + if (errno !=3D EAFNOSUPPORT && error !=3D EPROTONOSUPPORT) uq> > warn("socket(AF_INET6, SOCK_DGRAM)"); uq> > return; uq> > } uq> = uq> This gives undefined behavior, error is uninitialized at this point= .= uq> = uq> Found by: Coverity Scan, CID 1042128 = Gr, fixed just now. Thank you for the report! -- Hiroki ----Security_Multipart(Wed_Jul__3_18_51_50_2013_293)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlHT9DYACgkQTyzT2CeTzy3fnACgjvHVE7v9LSAF+Ju0D1sfamB3 t4UAoM7oXuub3FJ1FlcQ8mYahZncpeRl =OJBL -----END PGP SIGNATURE----- ----Security_Multipart(Wed_Jul__3_18_51_50_2013_293)----