From owner-freebsd-current@FreeBSD.ORG  Mon Aug  1 13:59:38 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E6234106567D;
	Mon,  1 Aug 2011 13:59:38 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id C0DE98FC1B;
	Mon,  1 Aug 2011 13:59:38 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 7AAB446B24;
	Mon,  1 Aug 2011 09:59:38 -0400 (EDT)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 1C64C8A02F;
	Mon,  1 Aug 2011 09:59:38 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-current@freebsd.org
Date: Mon, 1 Aug 2011 08:47:51 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110617; KDE/4.5.5; amd64; ; )
References: <4E35732A.8060807@FreeBSD.org>
In-Reply-To: <4E35732A.8060807@FreeBSD.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201108010847.52235.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Mon, 01 Aug 2011 09:59:38 -0400 (EDT)
Cc: Andriy Gapon <avg@freebsd.org>
Subject: Re: print_INTEL_info/print_INTEL_TLB
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Aug 2011 13:59:39 -0000

On Sunday, July 31, 2011 11:22:18 am Andriy Gapon wrote:
> 
> Just an observation:
> - print_INTEL_info and print_INTEL_TLB are missing from amd64 identcpu.c
> - print_INTEL_TLB doesn't cover all the codes defined by Intel specs
> - not sure; perhaps print_INTEL_info should use deterministic cache 
parameters
> as provided by CPUID 0x4 for a more complete coverage...

It might be nice to create a sys/x86/x86/identcpu.c to merge the two which 
would help with some of this.  print_INTEL_TLB() hasn't been updated since it 
was added AFAIK which probably explains why it doesn't know about all of the 
codes.

-- 
John Baldwin