From owner-freebsd-current@FreeBSD.ORG  Sun Nov  6 21:11:40 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C61A716A41F
	for <freebsd-current@FreeBSD.org>; Sun,  6 Nov 2005 21:11:40 +0000 (GMT)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (cell.sick.ru [217.72.144.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1418143D46
	for <freebsd-current@FreeBSD.org>; Sun,  6 Nov 2005 21:11:39 +0000 (GMT)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (glebius@localhost [127.0.0.1])
	by cell.sick.ru (8.13.3/8.13.3) with ESMTP id jA6LBPxA047576
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 7 Nov 2005 00:11:25 +0300 (MSK)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.sick.ru (8.13.3/8.13.1/Submit) id jA6LBPSR047575;
	Mon, 7 Nov 2005 00:11:25 +0300 (MSK)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.sick.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Mon, 7 Nov 2005 00:11:24 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Xin LI <delphij@gmail.com>
Message-ID: <20051106211124.GL91530@cell.sick.ru>
References: <84099c3d0511030325q6d1df92ag77310ff1b03a2d15@mail.gmail.com>
	<84099c3d0511030425q3592a288he254cb5f97f976b6@mail.gmail.com>
	<20051106144917.GA81664@comp.chem.msu.su>
	<a78074950511060705r500e0789y786af5d937bf1680@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <a78074950511060705r500e0789y786af5d937bf1680@mail.gmail.com>
User-Agent: Mutt/1.5.6i
Cc: Yar Tikhiy <yar@comp.chem.msu.su>, freebsd-current@FreeBSD.org,
	Taras Savchuk <taras.savchuk@gmail.com>
Subject: Re: May be a bug in fsck [ after super block crash on 5.4-STABLE ]
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Nov 2005 21:11:40 -0000

On Sun, Nov 06, 2005 at 11:05:28PM +0800, Xin LI wrote:
X> On 11/6/05, Yar Tikhiy <yar@comp.chem.msu.su> wrote:
X> > Isn't the type, UFS1 or UFS2, indicated by a magic number in the
X> > superblock itself?  I used to believe so.  If it's true, fsck cannot
X> > know the FS type prior to locating a superblock copy.  OTOH, with
X> > UFS2 having become popular, fsck might try both locations, 32 and 160.
X> > Care to file a PR?
X> 
X> That's correct.  Fortunately, given that we have some ways to validate
X> whether the superblock is valid, it is not too hard to automatically
X> detect which type the FS actually is.

I think this feature is already present in libufs, since dumpfs(8)
can detect UFS1/UFS2 type of filesystem.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE