From nobody Sat Feb 17 17:17:14 2024 X-Original-To: desktop@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tcb8C4crQz5BYX6 for ; Sat, 17 Feb 2024 17:17:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tcb8C1tt5z4v2C for ; Sat, 17 Feb 2024 17:17:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708190235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YxXx7T/ND1GngbzQV79Twooe0FOJG1zhsZzi+zpbR3Q=; b=ywgTEDTa3xTtv8WM8KwIs46NvPfrG8jloT+zEeuan5raKoo0+tQKoy5MlEXbYJnTRPoEH4 ujRmHLJweDu6ppD6x0nkYbeu+RxzLOTFBYrjrCHabRwbydr4CHPR9N9IvH5cua7PdXHKUp +jyESFdpDZq9XKNHdMY+6VtS5HwhXFihiCWiXj0EUZ3pPJdLxqqpMtgnPIF0z/Sg0k/9kp j86fE7wKHP2ClQukbLjBhAayLzrP0cwKN+0iYqOW/7aPjWaJVp8xhKl9iXlF7DpL8Q0KJJ fBGHik+BPxpbfVw7Xb7BTT59E0bL38jFhrNojxnk6BqNaYQkWIIx4d3ds/UFCA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708190235; a=rsa-sha256; cv=none; b=A7Yo6qk4JIPp+KDzLv9B3G14CHJYAPb2MA1hUZp1wFd8dubbkLhB9ZaxjNV7UeJQmyRVkY 58uPggovcJ8Xxt4h4HWXHFlS7PeppFioveGdAQ3fFWqQRidEp+mZoF5Vmffd00tYm1LnYm uBaosw0UaUWuixvQLDjhdVjZk7LgWPb/VcHbYocLc1f5yMZYXsLSViigI0VlMln81B1OJs 4HTn/Pv10lZia94qdjSiiuFonBO3AA88vVemvcB5mZacny5wyC7wB+SqBMGYWdn801XEKM OFjJWv2vX17yrNgRfjUstmhBr02989SlPqBnZhClaQe7+uhksW4svHvWdr9n6w== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Tcb8C0t1szH90 for ; Sat, 17 Feb 2024 17:17:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41HHHFQs074242 for ; Sat, 17 Feb 2024 17:17:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41HHHFrV074241 for desktop@FreeBSD.org; Sat, 17 Feb 2024 17:17:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: desktop@FreeBSD.org Subject: [Bug 277114] x11/lightdm: fix tty counting in patch-src_x-server.c Date: Sat, 17 Feb 2024 17:17:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dan.kotowski@a9development.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: desktop@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Using and improving FreeBSD on the desktop List-Archive: https://lists.freebsd.org/archives/freebsd-desktop List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-desktop@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277114 Bug ID: 277114 Summary: x11/lightdm: fix tty counting in patch-src_x-server.c Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: desktop@FreeBSD.org Reporter: dan.kotowski@a9development.com Assignee: desktop@FreeBSD.org Flags: maintainer-feedback?(desktop@FreeBSD.org) In patch-src_x-server.c we currently pass "ttyv%d", but we count TTYs in he= x, not decimal and so it should be: + tty_text =3D g_strdup_printf ("/dev/ttyv%x", vt - 1); This bug was identified in 221452, but the accepted patches bandage over the issue rather than fixing the root cause, which is the counting. This patch was suggested and actually resolves the bug: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D236106&action=3Ddiff However, it is also possible that these are base32 numbers rather than base= 16 and points here: https://github.com/swaywm/wlroots/pull/1945 With this fixed, it may again be possible to pull back in val's consolekit2 patch as well: https://github.com/valpackett/ConsoleKit2/commit/18a058576d118dec428d81c7e2= e3369d9ec939d0.patch --=20 You are receiving this mail because: You are the assignee for the bug.=