From owner-freebsd-ports@FreeBSD.ORG Sat Jun 23 09:23:18 2012 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 04AB61065672; Sat, 23 Jun 2012 09:23:18 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from smtp.infracaninophile.co.uk (smtp6.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3cd3:cd67:fafa:3d78]) by mx1.freebsd.org (Postfix) with ESMTP id 70CAD8FC0A; Sat, 23 Jun 2012 09:23:17 +0000 (UTC) Received: from seedling.black-earth.co.uk (seedling.black-earth.co.uk [81.187.76.163]) (authenticated bits=0) by smtp.infracaninophile.co.uk (8.14.5/8.14.5) with ESMTP id q5N9NChp005974 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 23 Jun 2012 10:23:13 +0100 (BST) (envelope-from matthew@FreeBSD.org) X-DKIM: OpenDKIM Filter v2.5.2 smtp.infracaninophile.co.uk q5N9NChp005974 Authentication-Results: smtp.infracaninophile.co.uk/q5N9NChp005974; dkim=none (no signature); dkim-adsp=none Message-ID: <4FE58AF8.9060203@FreeBSD.org> Date: Sat, 23 Jun 2012 10:23:04 +0100 From: Matthew Seaman User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Baptiste Daroussin References: <4FE12F2D.9080302@FreeBSD.org> <20120620061136.GA79164@ithaqua.etoilebsd.net> <4FE1829D.6030109@FreeBSD.org> <20120620091321.GA83730@ithaqua.etoilebsd.net> <20120620094431.M12775@martymac.org> <20120620103412.GB83730@ithaqua.etoilebsd.net> <4FE1C1EA.8070901@FreeBSD.org> <20120621090226.M48537@FreeBSD.org> <4FE4AEFC.4070405@FreeBSD.org> <4FE51858.4010502@FreeBSD.org> <20120623081843.GC41054@ithaqua.etoilebsd.net> In-Reply-To: <20120623081843.GC41054@ithaqua.etoilebsd.net> X-Enigmail-Version: 1.4.2 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig4C237409554FE9907D5C1889" X-Virus-Scanned: clamav-milter 0.97.5 at lucid-nonsense.infracaninophile.co.uk X-Virus-Status: Clean X-Spam-Status: No, score=-2.7 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lucid-nonsense.infracaninophile.co.uk Cc: FreeBSD Ports , Olli Hauer , Ganael LAPLANCHE , Doug Barton , Michael Scheidell Subject: Re: optionsng and tinderbox? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2012 09:23:18 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4C237409554FE9907D5C1889 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 23/06/2012 09:18, Baptiste Daroussin wrote: > Well the priority ordering the logical was to give the end word to the = last user > action. >=20 > It goes from global to specific >=20 > 1/ the global options (infrastructures) are applied > 2/ the maintainer option (ports are applied) > 3/ the user global options are applied (OPTIONS_{,UN}SET) > 4/ the user ports options are applied (${UNIQUENAME}_{,UN}SET) > 5/ the dialog (make config) options are applied >=20 > If that it looks not good to anyone, please comment (we can still chang= e it) and > please provide arguments. It's the ordering of 4 and 5 that confuses me. If you've got ${UNIQUENAME}_{,UN}SET in /etc/make.conf and then you run 'make config' you'ld expect the choices you make in the dialogue to be the final word. (ie. 5 overrides 4, as currently) (Would you expect the make.conf setting to affect what is shown in the dialog initially? Seems logical) On the other hand, if you run 'make foo_SET=3Dyes all' on a command line,= you'ld expect the command line to override anything saved in an options file (ie 4 overrides 5). I don't think you can have both of those behaviours in any reasonable way. If forced to choose, I'd prefer to have the capability to override a config setting as a one-off on the command line. Also given that in normal usage, selections would always be made in the options dialogue when the port was compiled, so they would always override any ${UNIQUENAME}_{,UN}SET setting in /etc/make.conf or from the command line. Which implies ${UNIQUENAME}_{,UN}SET only has any utility when the options dialogues are not used, such as in tinderbox or other port building systems. Swapping 4 and 5 would make the behaviour more consistent for all usage patterns. Cheers, Matthew --=20 Dr Matthew J Seaman MA, D.Phil. PGP: http://www.infracaninophile.co.uk/pgpkey --------------enig4C237409554FE9907D5C1889 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.16 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/liv8ACgkQ8Mjk52CukIw7AgCfXg1KWULgm8T4K8hEYoQkKj6f xlkAoI0qzS40X3E+/wbKkN2BBg1OH295 =eQcu -----END PGP SIGNATURE----- --------------enig4C237409554FE9907D5C1889--