Date: Thu, 07 Jul 2011 13:31:12 +0400 From: Pan Tsu <inyaoo@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/158702: [patch] www/firefox-devel: prune -DFREEBSD cruft in js Message-ID: <861uy2bfof.fsf@gmail.com> Resent-Message-ID: <201107070940.p679e6Hv044248@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 158702 >Category: ports >Synopsis: [patch] www/firefox-devel: prune -DFREEBSD cruft in js >Confidential: no >Severity: non-critical >Priority: low >Responsible: gecko >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Jul 07 09:40:05 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Pan Tsu >Release: FreeBSD 9.0-CURRENT amd64 >Organization: >Environment: gcc46 >Description: I think the issue[1] with hidden pthread_attr_get_np is gcc specific. pthread_np.h in config/system-headers should be enough to unhide it. [1] http://docs.freebsd.org/cgi/mid.cgi?86mxposuzj.fsf >How-To-Repeat: 1. build with gcc45 and basegcc 2. nm -D /usr/local/lib/firefox/libxul.so | grep 'pthread.*attr' >Fix: --- a.diff begins here --- Index: www/firefox-aurora/files/patch-js-src-jsnativestack.cpp =================================================================== --- www/firefox-aurora/files/patch-js-src-jsnativestack.cpp (revision 587) +++ www/firefox-aurora/files/patch-js-src-jsnativestack.cpp (working copy) @@ -1,12 +0,0 @@ ---- js/src/jsnativestack.cpp.orig 2011-06-01 00:33:48.000000000 +0200 -+++ js/src/jsnativestack.cpp 2011-06-01 00:56:21.718439794 +0200 -@@ -50,7 +50,8 @@ - #elif defined(XP_MACOSX) || defined(DARWIN) || defined(XP_UNIX) - # include <pthread.h> - --# if defined(__FreeBSD__) || defined(__OpenBSD__) -+# if defined(FREEBSD) || defined(__OpenBSD__) -+# include <cstddef> - # include <pthread_np.h> - # endif - Index: www/firefox-aurora/files/patch-js-src-Makefile.in =================================================================== --- www/firefox-aurora/files/patch-js-src-Makefile.in (revision 587) +++ www/firefox-aurora/files/patch-js-src-Makefile.in (working copy) @@ -28,12 +28,11 @@ INCLUDES += -I$(srcdir) -@@ -793,7 +796,8 @@ +@@ -793,7 +796,7 @@ endif # WINNT ifeq ($(OS_ARCH),FreeBSD) -EXTRA_LIBS += -pthread -+DEFINES += -DFREEBSD +EXTRA_LIBS += -pthread -lc endif ifeq ($(OS_ARCH),IRIX) --- a.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?861uy2bfof.fsf>