From owner-svn-src-all@FreeBSD.ORG Tue Sep 23 18:31:50 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8C82EC3A for ; Tue, 23 Sep 2014 18:31:50 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6C90D6DB for ; Tue, 23 Sep 2014 18:31:50 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id s8NIVoRb064316 for ; Tue, 23 Sep 2014 18:31:50 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id s8NIVoGW064314 for svn-src-all@freebsd.org; Tue, 23 Sep 2014 18:31:50 GMT (envelope-from bdrewery) Received: (qmail 87722 invoked from network); 23 Sep 2014 13:31:47 -0500 Received: from unknown (HELO ?10.10.0.24?) (freebsd@shatow.net@10.10.0.24) by sweb.xzibition.com with ESMTPA; 23 Sep 2014 13:31:47 -0500 Message-ID: <5421BC8E.6000709@FreeBSD.org> Date: Tue, 23 Sep 2014 13:31:42 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Konstantin Belousov Subject: Re: svn commit: r272032 - head/sys/conf References: <201409231704.s8NH4Lcv098184@svn.freebsd.org> <20140923182051.GF8870@kib.kiev.ua> In-Reply-To: <20140923182051.GF8870@kib.kiev.ua> OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9PopXo3P8qq6o2Bi1nmsJHRlpAuSQNG93" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2014 18:31:50 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9PopXo3P8qq6o2Bi1nmsJHRlpAuSQNG93 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 9/23/2014 1:20 PM, Konstantin Belousov wrote: > On Tue, Sep 23, 2014 at 05:04:21PM +0000, Bryan Drewery wrote: >> Author: bdrewery >> Date: Tue Sep 23 17:04:21 2014 >> New Revision: 272032 >> URL: http://svnweb.freebsd.org/changeset/base/272032 >> >> Log: >> DEBUG_LOCKS no longer modifies 'struct vnode', nor does fstat(1) use= it. >> fstat(1) now uses libprocstat(9). There is no userland impact to us= ing this. >=20 > DEBUG_VFS_LOCKS does modify KBI of VFS, by adding struct stack to > lockmgr, and lockmgr is embedded into each struct vnode. >=20 > VFS modules, in particular, filesystems, compiled for mismatched > kernel WRT DEBUG_VFS_LOCKS, would cause strange breakage. Well, perhaps the comment needs to be updated to state that DEBUG_VFS_LOCKS modifies VFS KBI so any VFS modules will need to recompil= ed. I did see the stack was moved to lockmgr, but given the use of libprocstat, and lockmgr being a kernel struct, I don't think it's worth mentioning userland here. Sound good? >=20 >> =20 >> MFC after: 3 days >> >> Modified: >> head/sys/conf/NOTES >> >> Modified: head/sys/conf/NOTES >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/sys/conf/NOTES Tue Sep 23 16:06:28 2014 (r272031) >> +++ head/sys/conf/NOTES Tue Sep 23 17:04:21 2014 (r272032) >> @@ -2625,9 +2625,7 @@ options NSFBUFS=3D1024 >> # Enable extra debugging code for locks. This stores the filename an= d >> # line of whatever acquired the lock in the lock itself, and changes = a >> # number of function calls to pass around the relevant data. This is= >> -# not at all useful unless you are debugging lock code. Also note >> -# that it is likely to break e.g. fstat(1) unless you recompile your >> -# userland with -DDEBUG_LOCKS as well. >> +# not at all useful unless you are debugging lock code. >> # >> options DEBUG_LOCKS >> =20 --=20 Regards, Bryan Drewery --9PopXo3P8qq6o2Bi1nmsJHRlpAuSQNG93 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJUIbyOAAoJEDXXcbtuRpfPAMcH+wZrGw30oCPVbEuLAxsyyEMh 8bywkuRdvYtmcCyUE8iULukbpjlDe/VWs/rDJfS1i2CDlNq0JscLiitEtKWFCxoY bza0nYRScmgJCbCdDBLsijXJVbrKxK0Mlb+KYkP2iz2lIWXUSOPwjh9vM7UKCEX4 nHhGeCWCcKm5WfJ9k88OHH5Uqqp1xojaC4dJWDMFipUhCQ4rhF/snoHIcWc0qYcX QDAC40Hq+1BsP2FYXmTJAn8zWJbNyUhRMXamkxm1nxMHkrvc6jPL2ZyYj/BKOKcl YMpsgY36XNF8u9upTn4EKJo4JbCgUqZkGFi7wInR64HhhnanGPZAF0CSdKsex08= =E2cU -----END PGP SIGNATURE----- --9PopXo3P8qq6o2Bi1nmsJHRlpAuSQNG93--