From owner-p4-projects@FreeBSD.ORG  Wed May  9 19:25:48 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3625516A402; Wed,  9 May 2007 19:25:48 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id CF86516A403
	for <perforce@freebsd.org>; Wed,  9 May 2007 19:25:47 +0000 (UTC)
	(envelope-from fli@shapeshifter.se)
Received: from mx1.h3q.net (mx1.h3q.net [212.37.5.30])
	by mx1.freebsd.org (Postfix) with ESMTP id 88FEF13C45E
	for <perforce@freebsd.org>; Wed,  9 May 2007 19:25:47 +0000 (UTC)
	(envelope-from fli@shapeshifter.se)
Received: from [192.168.1.100] (81-232-22-115-no50.tbcn.telia.com
	[81.232.22.115])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	(Authenticated sender: fli@shapeshifter.se)
	by mx1.h3q.net (Postfix) with ESMTP id D766A78C20;
	Wed,  9 May 2007 21:25:45 +0200 (CEST)
Message-ID: <46422038.4030409@shapeshifter.se>
Date: Wed, 09 May 2007 21:25:44 +0200
From: Fredrik Lindberg <fli@shapeshifter.se>
User-Agent: Thunderbird 2.0.0.0 (X11/20070420)
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>
References: <200705082229.l48MTrbh069129@repoman.freebsd.org>
	<9bbcef730705090710h653dc15bjb7a1159484c1c48b@mail.gmail.com>
	<4641E19F.80809@shapeshifter.se>
	<200705091505.39795.jhb@freebsd.org>
In-Reply-To: <200705091505.39795.jhb@freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Perforce Change Reviews <perforce@freebsd.org>,
	Ivan Voras <ivoras@gmail.com>
Subject: Re: PERFORCE change 119527 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 May 2007 19:25:48 -0000

John Baldwin wrote:
> On Wednesday 09 May 2007 10:58:39 am Fredrik Lindberg wrote:
>> Ivan Voras wrote:
>>> On 09/05/07, Fredrik Lindberg <fli@shapeshifter.se> wrote:
>>>
>>>> Ok, I'll take a look at the various queue.h shipped with the major BSDs,
>>>> and see if I can find a common subset that suits my needs (without too
>>>> many compromises) and based on the findings I'll reconsider my choice.
>>> I use sys/queue.h in my userland applications all the time, there's no
>>> problem there.
>>>
>> And it works on {Net,Open}BSD?, I could swear that I've been bitten by
>> sys/queue.h in the past when moving stuff between FreeBSD and NetBSD.
>> Could have been those TAILQ-macros Robert Watson talked about though.
> 
> Just include your own copy of sys/queue.h for systems whose queue.h isn't up 
> to snuff.  You don't have to use the OS-native one, it's ok to carry one 
> around, but then you have one less copy of the wheel.
> 

Yes, that's true. We can drop this discussion/bikeshed now, I submitted
a change ~3 hours ago :)


http://perforce.freebsd.org/chv.cgi?CH=119564

Change 119564 by fli@fli_genesis on 2007/05/09 16:13:23

	Nuke my own-rolled list and replace with sys/queue.h