From owner-cvs-all Sat Dec 12 19:00:34 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id TAA01358 for cvs-all-outgoing; Sat, 12 Dec 1998 19:00:34 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from awfulhak.org (awfulhak.force9.co.uk [195.166.136.63]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA01351 for ; Sat, 12 Dec 1998 19:00:30 -0800 (PST) (envelope-from brian@Awfulhak.org) Received: from keep.lan.Awfulhak.org (keep.lan.Awfulhak.org [172.16.0.8]) by awfulhak.org (8.8.8/8.8.8) with ESMTP id BAA01956; Sun, 13 Dec 1998 01:36:46 GMT (envelope-from brian@Awfulhak.org) Received: from keep.lan.Awfulhak.org (localhost [127.0.0.1]) by keep.lan.Awfulhak.org (8.9.1/8.9.1) with ESMTP id BAA00742; Sun, 13 Dec 1998 01:38:00 GMT (envelope-from brian@keep.lan.Awfulhak.org) Message-Id: <199812130138.BAA00742@keep.lan.Awfulhak.org> X-Mailer: exmh version 2.0.2 2/24/98 To: Matthew Dillon cc: committers@FreeBSD.ORG Subject: Re: Proposed changes to fix bounds checking in alias_nbt.c In-reply-to: Your message of "Sat, 12 Dec 1998 14:59:05 PST." <199812122259.OAA03354@apollo.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 13 Dec 1998 01:38:00 +0000 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > While looking at PR bin/8962, I found that > /usr/src/lib/libalias/alias_nbt.c is completely broken - it does no > bounds checking whatsoever. None. Zilch. > > Below is a proposed diff, and after that is the complete file. I would > appreciate it if someone looked over it. I cannot easily test it because > I don't run NAT. [.....] I'll certainly eyeball them either tomorrow (Sunday) or Monday and send back any findings. I don't run any NetBIOS stuff through libalias, but I'll try to set up a test case. Cheers. -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message