From owner-freebsd-arch Tue May 16 14:18:28 2000 Delivered-To: freebsd-arch@freebsd.org Received: from berserker.bsdi.com (berserker.twistedbit.com [199.79.183.1]) by hub.freebsd.org (Postfix) with ESMTP id 6140637B797 for ; Tue, 16 May 2000 14:18:26 -0700 (PDT) (envelope-from cp@berserker.bsdi.com) Received: from berserker.bsdi.com (cp@LOCALHOST [127.0.0.1]) by berserker.bsdi.com (8.9.3/8.9.3) with ESMTP id PAA14892; Tue, 16 May 2000 15:18:12 -0600 (MDT) Message-Id: <200005162118.PAA14892@berserker.bsdi.com> To: "Jeroen C. van Gelderen" Cc: Doug Rabson , arch@freebsd.org Subject: Re: A new api for asynchronous task execution (2) From: Chuck Paterson Date: Tue, 16 May 2000 15:18:12 -0600 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG "Jeroen C. van Gelderen" wrote on: Tue, 16 May 2000 17:04:55 EDT }Doug Rabson wrote: }[...] }> #define TQ_DEF 0 /* use blocking mutex */ } }Minor nits: } }If this means default, I'd rename it to TQ_DEFAULT. No need to }be cryptic, preprocessors can handle legible names these days. } }Additionally, it may be useful to be able to explicitly specify }TQ_BLOCKING in case the default ever changes. } Just an FYI, the TQ_DEF probably came from the flag passed into the BSD/OS mutex macros which is M_DEF. These are short because the macros often get used when there is sever indenting and it is much easer to read when they don't cause a line split. Also they are used ALL over the place and after looking at the code for a few minutes there is never any doubt what they stand for. Chuck To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message