Date: Thu, 15 Nov 2012 10:38:54 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Florian Smeets <flo@smeets.im> Cc: svn-ports-head@FreeBSD.org, Emanuel Haupt <ehaupt@critical.ch>, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r307446 - head/www/xpi-colorfultabs Message-ID: <20121115103854.GA66564@FreeBSD.org> In-Reply-To: <50A4C343.7080501@smeets.im> References: <201211151016.qAFAGgQj064519@svn.freebsd.org> <20121115112221.ba4ce4e361a4fe5f627f0199@critical.ch> <50A4C343.7080501@smeets.im>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 15, 2012 at 11:26:11AM +0100, Florian Smeets wrote:
> On 11/15/2012 11:22, Emanuel Haupt wrote:
> > These two files are probably not needed.
>
> Yeah, i know. I saw them but decided to just add them to the plist,
> rather than hacking up the Makefile with something to use find on the
> WRKSRC and delete them.
>
> If anybody sees this as a problem, i can hack the Makefile to delete
> them prior to installation.
Yes, it is a problem. It makes us (FreeBSD) look like careless fools not
even able (or giving a shit about) to keep crap out of the packages we ship.
These things add up, regardless of how non-functional they might be, to the
bad impression of us. Please try to make ports nice and clean, remove the
crap, it's very easy:
post-extract:
# Remove the crap
@${FIND} ${WRKSRC} -type f -name ... -delete
Slighly longer for directories.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121115103854.GA66564>