From owner-svn-src-all@freebsd.org  Sun Jul  2 16:21:06 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CF095DA8B55
 for <svn-src-all@mailman.ysv.freebsd.org>;
 Sun,  2 Jul 2017 16:21:06 +0000 (UTC)
 (envelope-from allanjude@freebsd.org)
Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B07F76FD35
 for <svn-src-all@freebsd.org>; Sun,  2 Jul 2017 16:21:06 +0000 (UTC)
 (envelope-from allanjude@freebsd.org)
Received: from [10.1.1.2] (unknown [10.1.1.2])
 (Authenticated sender: allanjude.freebsd@scaleengine.com)
 by mx1.scaleengine.net (Postfix) with ESMTPSA id 864C613C9C;
 Sun,  2 Jul 2017 16:20:59 +0000 (UTC)
Subject: Re: svn commit: r320555 - head/usr.sbin/diskinfo
To: "N.J. Mann" <njm@njm.me.uk>
Cc: svn-src-all@freebsd.org
References: <201707012134.v61LYvFc026064@repo.freebsd.org>
 <613933F1305AF7B7EDEED034@triton.njm.me.uk>
From: Allan Jude <allanjude@freebsd.org>
Message-ID: <5023c7b7-022c-32bd-427a-eb0e5d36e010@freebsd.org>
Date: Sun, 2 Jul 2017 12:20:58 -0400
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <613933F1305AF7B7EDEED034@triton.njm.me.uk>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Jul 2017 16:21:06 -0000

On 2017-07-02 02:19, N.J. Mann wrote:
> Hi,
> 
> 
> On Saturday, July 01, 2017 21:34:57 +0000 Allan Jude <allanjude@FreeBSD.org> wrote:
>> Author: allanjude
>> Date: Sat Jul  1 21:34:57 2017
>> New Revision: 320555
>> URL: https://svnweb.freebsd.org/changeset/base/320555
>>
>> Log:
>>   Add -s (serial) and -p (physpath) to diskinfo
> 
> [...]
> 
>> @@ -52,6 +58,12 @@ Print fields one per line with a descriptive comment.
>>  Perform a simple measurement of the I/O read command overhead.
>>  .It Fl i
>>  Perform a simple IOPS benchmark.
>> +.It Fl p
>> +Return the physical path of the disk.
>> +This is a string that identifies the physical path to the disk in the
>> +storage enclsoure.
> 
>            ^^^^^^^^^^
> 
>> +.It Fl s
>> +Return the disk serial number
>>  .It Fl t
>>  Perform a simple and rather naive benchmark of the disks seek
>>  and transfer performance.
>> @@ -62,6 +74,13 @@ with the following fields: device name, sectorsize, me
>>  media size in sectors, stripe size, stripe offset, firmware cylinders,
>>  firmware heads, and firmware sectors.
>>  The last three fields are only present if the information is available.
>> +.It Fl i
>> +Return the disk ident, usually the serial number.
>> +.It Fl p
>> +Return the physical path of the disk.
>> +This is a string that identifies the physical path to the disk in the
>> +storage enclsoure.
> 
>            ^^^^^^^^^^
> 
> 
> Cheers,
>        Nick.
> 

Fixed, thank you.

-- 
Allan Jude