Date: Sat, 2 Feb 2019 19:30:18 -0500 From: Patrick Kelsey <pkelsey@freebsd.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343688 - head/sys/dev/vmware/vmxnet3 Message-ID: <CAD44qMWHXuMsAS=kDouqjkOSEvGgV6r3RKwuickGVKoL=pUj3Q@mail.gmail.com> In-Reply-To: <7D5D3255-CF9C-4F13-A0A9-965AA2E7AE81@gmail.com> References: <201902022114.x12LEsE8058821@repo.freebsd.org> <7D5D3255-CF9C-4F13-A0A9-965AA2E7AE81@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 2, 2019 at 7:27 PM Enji Cooper <yaneurabeya@gmail.com> wrote: > Hi Patrick, > > On Feb 2, 2019, at 13:14, Patrick Kelsey <pkelsey@freebsd.org> wrote: > > Author: pkelsey > Date: Sat Feb 2 21:14:53 2019 > New Revision: 343688 > URL: https://svnweb.freebsd.org/changeset/base/343688 > > Log: > Fix interrupt index configuratoin when using MSI interrupts. > > When in MSI mode, the device was only being configured with one > interrupt index, but it needs two - one for the actual interrupt and > one to park the tx queue at. > > Also clarified comments relating to interrupt index assignment. > > Reported by: Yuri Pankov <yuripv@yuripv.net> > MFC after: 1 day > > > Does this change partly fix > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203874 ? > No, this fixes the behavior of the iflib version of the vmx(4) driver when that bug causes its interrupt configuration code to fall into the MSI path (because MSI-X has been blacklisted). -Patrick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAD44qMWHXuMsAS=kDouqjkOSEvGgV6r3RKwuickGVKoL=pUj3Q>