From owner-cvs-all@FreeBSD.ORG  Tue Jan 13 11:00:46 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B900516A5D5; Tue, 13 Jan 2004 11:00:46 -0800 (PST)
Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 14F8343D55; Tue, 13 Jan 2004 11:00:05 -0800 (PST)
	(envelope-from obrien@dragon.nuxi.com)
Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1])
	by dragon.nuxi.com (8.12.10/8.12.9) with ESMTP id i0DJ04ip030399;
	Tue, 13 Jan 2004 11:00:04 -0800 (PST)
	(envelope-from obrien@dragon.nuxi.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.12.10/8.12.10/Submit) id i0DJ03Gx030398;
	Tue, 13 Jan 2004 11:00:03 -0800 (PST)
	(envelope-from obrien)
Date: Tue, 13 Jan 2004 11:00:03 -0800
From: "David O'Brien" <obrien@FreeBSD.org>
To: Edwin Groothuis <edwin@FreeBSD.org>
Message-ID: <20040113190003.GA30277@dragon.nuxi.com>
References: <200401130829.i0D8TStA046149@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200401130829.i0D8TStA046149@repoman.freebsd.org>
User-Agent: Mutt/1.4.1i
X-Operating-System: FreeBSD 5.2-CURRENT
Organization: The NUXI BSD Group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/mail/p5-Mail-SpamAssassin Makefile pkg-plist
	ports/mail/p5-Mail-SpamAssassin/files spamd.sh
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: obrien@FreeBSD.org
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Jan 2004 19:00:47 -0000

On Tue, Jan 13, 2004 at 12:29:28AM -0800, Edwin Groothuis wrote:
> edwin       2004/01/13 00:29:28 PST
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     mail/p5-Mail-SpamAssassin Makefile pkg-plist 
>     mail/p5-Mail-SpamAssassin/files spamd.sh 
>   Log:
>   [PATCH] mail/p5-Mail-SpamAssassin 2.60
>   
>           This patch adds rc_subr support to spamd daemon
>           of the spamassassin port.
>   
>   PR:             ports/57384

Why does this have to be so complicated?? 


    +USE_RC_SUBR=   yes
    +RC_DIR=                ${PREFIX}/etc/rc.d
    +RC_SUFX=       .sh
    +SED_SCRIPT+=   -e 's|%%RC_SUBR%%|${RC_SUBR}|g' \
    +               -e 's|%%RC_DIR%%|${RC_DIR}|g' \
    +               -e 's|%%RC_SUFX%%|${RC_SUFX}|g'
    +PLIST_SUB+=    RC_DIR=${RC_DIR} \
    +               RC_SUFX=${RC_SUFX}


* Is RC_SUFX changing anytime soon?  Isn't it always ".sh"?
* Doesn't the PLIST_SUB for RC_DIR put absolute paths into the PLIST,
  which isn't needed.  PLIST already has %D for that.