From owner-freebsd-transport@freebsd.org Mon Jan 28 11:29:53 2019 Return-Path: Delivered-To: freebsd-transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 29F3514AFBFB for ; Mon, 28 Jan 2019 11:29:53 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-eopbgr780048.outbound.protection.outlook.com [40.107.78.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D4EF586A43 for ; Mon, 28 Jan 2019 11:29:51 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netapp.onmicrosoft.com; s=selector1-netapp-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6I4rOiCmioDsSOiRO9nsBUdJAmM8UGgJwH2Nx5Jv6mc=; b=rJ9+jS/NZF+zZmwUf/cPy4YUrwqOqz3DeH5HJ9dwm7TzLLe6Cyb5q7tbgouBwT2/oikxLAqtjm8FGDJ+p0GIZJ67Wd3L2mDK1GJYFuBQxkEzhusJb73NOxzp0a3nPUApjgCwgEeoV8RYZPLxdnCYqhVSlhXVfeAAmRusmoLPq8E= Received: from SN4PR0601MB3728.namprd06.prod.outlook.com (10.167.151.152) by SN4PR0601MB3693.namprd06.prod.outlook.com (10.167.133.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.16; Mon, 28 Jan 2019 11:29:49 +0000 Received: from SN4PR0601MB3728.namprd06.prod.outlook.com ([fe80::9de7:64d4:a405:784d]) by SN4PR0601MB3728.namprd06.prod.outlook.com ([fe80::9de7:64d4:a405:784d%5]) with mapi id 15.20.1558.023; Mon, 28 Jan 2019 11:29:49 +0000 From: "Scheffenegger, Richard" To: "freebsd-transport@freebsd.org" Subject: RE: IW10 broken when not doing ABC Thread-Topic: IW10 broken when not doing ABC Thread-Index: AdS2jcyZRsjylB8KRk+KqJh59kJ8ywAbh13A Date: Mon, 28 Jan 2019 11:29:49 +0000 Message-ID: References: In-Reply-To: Accept-Language: de-AT, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcc3JpY2hhcmRcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5ZTM1Ylxtc2dzXG1zZy0wNGNkNDIxZS0yMmYwLTExZTktYjVlZC0wMDE5ZDJlNGVjZDdcYW1lLXRlc3RcMDRjZDQyMjAtMjJmMC0xMWU5LWI1ZWQtMDAxOWQyZTRlY2Q3Ym9keS50eHQiIHN6PSIyNTY3IiB0PSIxMzE5MzE0ODU4OTAxODE4NDEiIGg9Ik5ZS21yN1BaK3dIZ3pJZDFXT0hTbnBPRGw0OD0iIGlkPSIiIGJsPSIwIiBibz0iMSIvPjwvbWV0YT4= x-dg-rorf: x-originating-ip: [213.143.121.76] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN4PR0601MB3693; 6:4zIBJQblwLSJsAdZifg2yK5FV4ccdCMZeh71tdtfG8jfLmSiHKWe07Y5wcm2jjtQECQZsHGoePbRZa+M6rgp40DZSmFtzQ8b/VDGtoTKlA2ZdFpqf+NikgCmm81FeVRYTjhftEtsLTknlWtRQYe286zYYyYinbyihLW1mdG/3kPknSfyeiTo6uUgteWHj7y7RY8T3qDZnVA2+wHdg9wRfIbYdjYDoqpCOqWYqdM2IT0rdEdjJMurvWRiZ8SQKsSTVGMdn49YvHozlEleTKc/uh9263cb2WClK0FAO42xwT7HVKY12Y1QDhj0LWQnjM9kt3ZgTqSoUC3C5nIV3nyDiBwF6aSkLT5wJm5C2skzmjyYchEUBY0kqX8NexZtcjo8c1uQnwjAwROZJbK8/Xyckul8+3ZN4j4QXo37IRtrpfgtI7Lsc15U9u3kuxvW8TUvwBvLBecOmfCA4ioiFIHlFg==; 5:+opsmp+4hoo7FWKbD11ikq9Y2jv2V63qDsxbArG7F1Lj8Q121g+hi8QXoje7ShPf/3Jr8ZyYq0830Ppe4B3svtjDgdrxfMMADli3NHEFxQ9ohHpWrB9NOqFdql1aFaAvIELtiFk9YsbzeBa5JG5jwd7uugeJXGkPcBowLo7RGL2oMqu0erwNWnMrFsE9Ol7b/2enMoH+6EDxpINieSYlug==; 7:/jKw39KvdPeGLL5RJqvELOVFVlRUAFdrsdQT56+x7WPbu1ZugOkblSk7J9XE5Vhtq6zaB2g7yuK/pZ64CA2S+17UxpTx2VVDHlVeaA8giuiOMiiuNnjSEtiXuGQ5xUPrqaNiMaamkKrvUC+ZlqiqZA== x-ms-office365-filtering-correlation-id: 5194ad9a-dad9-4cc7-7938-08d68513e9c6 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(2017052603328)(7193020); SRVR:SN4PR0601MB3693; x-ms-traffictypediagnostic: SN4PR0601MB3693: x-microsoft-antispam-prvs: x-forefront-prvs: 0931CB1479 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(136003)(39860400002)(376002)(396003)(189003)(199004)(13464003)(2351001)(14454004)(966005)(71200400001)(72206003)(71190400001)(25786009)(6246003)(33656002)(2501003)(3846002)(6116002)(478600001)(106356001)(105586002)(68736007)(5640700003)(53936002)(6306002)(305945005)(55016002)(7736002)(6916009)(6436002)(476003)(2906002)(9686003)(186003)(66066001)(102836004)(6506007)(99286004)(81156014)(81166006)(14444005)(256004)(74316002)(26005)(7696005)(229853002)(86362001)(97736004)(11346002)(446003)(8936002)(8676002)(76176011)(486006)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN4PR0601MB3693; H:SN4PR0601MB3728.namprd06.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: netapp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Ca8q/G5JHVqWRLa4Y17imbfEoV6h/5XXI9NPvdwKrTwh08N+F1M4BjjcYOyZYAsJChT51x03gZk+ayTHeLsGFj7pxxrCuviotxCsrYyevkj1UyS4z8349RVRIHMRjIVParbzv6EwNtHqrgTqrRtCPN/C4+vT1+JYhYpNOyV1Y8xfN/nrDSxtqeOCB4Nw+Wbka0BdAQPm0Piklx3JnhnwsFPlNT+paC7il8zPVfHBkwqZuLb5GMPua24TxQg83KcJe7UB1jg4EfmtLklqGD8ussXOkMem30KHS/STg7utBv5I6Kex3gkmdifsyRdMsYenwJg0H8p+RQw2rLybnAF9cH9qVj4DBz+INOjFHT+6anbTJ/C4G1ZITaaBgQe6KAzaiAYFz4GrGyL33WsnN/kaYHCt6xAusi5XYPk935vaSng= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: netapp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5194ad9a-dad9-4cc7-7938-08d68513e9c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2019 11:29:49.0944 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4b0911a0-929b-4715-944b-c03745165b3a X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0601MB3693 X-Rspamd-Queue-Id: D4EF586A43 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=netapp.onmicrosoft.com header.s=selector1-netapp-com header.b=rJ9+jS/N; spf=pass (mx1.freebsd.org: domain of Richard.Scheffenegger@netapp.com designates 40.107.78.48 as permitted sender) smtp.mailfrom=Richard.Scheffenegger@netapp.com X-Spamd-Result: default: False [-1.66 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.74)[-0.742,0]; R_DKIM_ALLOW(-0.20)[netapp.onmicrosoft.com:s=selector1-netapp-com]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[netapp.com]; NEURAL_HAM_LONG(-0.96)[-0.958,0]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_SPAM_SHORT(0.55)[0.554,0]; MX_GOOD(-0.01)[cached: mx1.netapp.iphmx.com]; DKIM_TRACE(0.00)[netapp.onmicrosoft.com:+]; RCVD_IN_DNSWL_NONE(0.00)[48.78.107.40.list.dnswl.org : 127.0.3.0]; TO_DN_EQ_ADDR_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[] X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2019 11:29:53 -0000 After some investigation about the most effective course of action, which f= ixes the non-ABC misbehavor and the Special case of the sequence space occupied by the SYN bit, I came up with = the following https://reviews.freebsd.org/D19000 It's also fixing the smaller nuisance of the 1 byte cwnd inflation for SYN = when doing ABC. In case the SYN,ACK or final ACK already contain data, this patch won't cha= nge the processing order. The common case of these segments containing no data is handled by updating= snd_una before additional ACK processing can inflate the initial window, matching previous comments i= n the code about the processing flow again. A couple of reviewers would be highly appreciated in this core area of sess= ion set-up, so that I've not missed any side-effect. Also, I don't know how to bind https://bugs.freebsd.org/bugzilla/show_bug.c= gi?id=3D235256 against this patch. Best regards, Richard -----Original Message----- Hi, Just added this comment to D18940. Would appreciate it, if someone other th= an me can confirm this behavior, which may have been present for some time = already. Also, I found some other oddities around ABC calculation in modular congest= ion control, but want to discuss them internally first; if anyone is having= time and wants to also investigate, please PM. Best regards, Richard Subject: [Differential] D18940: Consolidate Initial Window calculations I was just starting to validate something around RTO, and found, that the= effective IW is now actually 11 SMSS, not 10 MSS, when NOT doing ABC (net.= inet.tcp.rfc3465=3D0). I suspect, the final ACK of the 3WHS is already processed in the normal A= CK path, increasing cwnd at that point by one MSS. Here is the corresponding Packetdrill script (named for what I wanted to = validate, before hitting this). F4175462: newreno-slowstart-after-rto.pkt REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D18940/new/ REVISION DETAIL https://reviews.freebsd.org/D18940 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: rscheff_gmx.at, #transport, tuexen Cc: imp, thj, rscheff_gmx.at _______________________________________________ freebsd-transport@freebsd.org mailing list https://lists.freebsd.org/mailma= n/listinfo/freebsd-transport To unsubscribe, send any mail to "freebsd-transport-unsubscribe@freebsd.org= "