Date: Wed, 14 Mar 2001 15:09:51 -0800 (PST) From: anarcat@tao.ca To: freebsd-gnats-submit@FreeBSD.org Subject: ports/25814: [PATCH] audio/ecasound: various fixes Message-ID: <200103142309.f2EN9pc86650@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 25814
>Category: ports
>Synopsis: [PATCH] audio/ecasound: various fixes
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Mar 14 15:10:01 PST 2001
>Closed-Date:
>Last-Modified:
>Originator: The Anarcat
>Release: 4.3-BETA
>Organization:
Nada, Inc.
>Environment:
FreeBSD shall.anarcat.yi.org 4.3-BETA FreeBSD 4.3-BETA #1: Fri Mar 9 08:37:33 EST 2001 root@shall.anarcat.yi.org:/usr/obj/usr/src/sys/SHALL i386
Recent ports collection.
>Description:
The annoying port email brought to me a couple of issues with this port I maintain.
Actually, the problem is that the ecasound port can optionally be compiled with
python so that you have another interface to the program. The python dependency
wasn't recorded in the makefile and the port was building the python bits by
default, so the process of installing or packaging failed a one point.
>How-To-Repeat:
cd /usr/ports/audio/ecasound && make install package
>Fix:
The fix is quite simple. And it features a couple of other enhancments.
First off, the current plist must be renamed "pkg-plist.py".
Second, a new plist must be made with the following diff on the original:
--- pkg-plist.py Wed Mar 14 17:48:27 2001
+++ pkg-plist Wed Mar 14 17:48:37 2001
@@ -140,9 +140,6 @@
lib/ecasound-plugins/libaudioio_arts.so
share/ecasound/effect_presets
share/ecasound/generic_oscillators
-lib/python1.5/site-packages/pyeca.py
-lib/python1.5/site-packages/libpyecasound.la
-lib/python1.5/site-packages/libpyecasound.so
@dirrm share/ecasound
@dirrm include/ecasound
@dirrm lib/ecasound-plugins
And now, the grand hack of the makefile goes as follows. Note that
I do not know the "proper" (tm) way to do this (how'd you call that?
"optional dependencies?").
This also enables flags to require dependencies on a few other packages
ecasound uses.
--- /usr/ports/audio/ecasound/Makefile Tue Dec 26 00:52:15 2000
+++ Makefile Wed Mar 14 18:05:33 2001
@@ -14,11 +14,30 @@
MAINTAINER= anarcat@tao.ca
-# RUN_DEPENDS= mpg123:${PORTSDIR}/audio/mpg123 \
-# lame:${PORTSDIR}/audio/lame \
-# mikmod:${PORTSDIR}/audio/mikmod
+.if defined(WITH_MPG123)
+RUN_DEPENDS+= mpg123:${PORTSDIR}/audio/mpg123
+.endif
-# LIB_DEPENDS= audiofile.0:${PORTSDIR}/audio/libaudiofile
+.if defined(WITH_LAME)
+RUN_DEPENDS+= lame:${PORTSDIR}/audio/lame
+.endif
+
+.if defined(WITH_MIKMOD)
+RUN_DEPENDS+= mikmod:${PORTSDIR}/audio/mikmod
+.endif
+
+.if defined(WITH_AUDIOFILE)
+LIB_DEPENDS+= audiofile.0:${PORTSDIR}/audio/libaudiofile
+.else
+CONFIGURE_ARGS+= --disable-audiofile
+.endif
+
+.if defined(WITH_PYECASOUND)
+USE_PYTHON= yes
+PLIST?= ${PKGDIR}/pkg-plist.py
+.else
+CONFIGURE_ARGS+= --disable-pyecasound
+.endif
GNU_CONFIGURE= yes
USE_GMAKE= yes
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200103142309.f2EN9pc86650>