From owner-freebsd-current@FreeBSD.ORG  Fri Oct 10 09:52:20 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9D99B16A4B3
	for <current@freebsd.org>; Fri, 10 Oct 2003 09:52:20 -0700 (PDT)
Received: from mailproxy.de.uu.net (mailproxy.de.uu.net [192.76.144.34])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 80E3343FBD
	for <current@freebsd.org>; Fri, 10 Oct 2003 09:52:18 -0700 (PDT)
	(envelope-from tmueller@thmu.de)
Received: from nomad.thmu.de (1Cust14.tnt3.str2.deu.da.uu.net [149.225.44.14])
	by mailproxy.de.uu.net (8.9.3p2/5.5.5) with SMTP id SAA13599;
	Fri, 10 Oct 2003 18:49:52 +0200 (MET DST)
Date: Fri, 10 Oct 2003 18:50:26 +0200
From: Thomas Mueller <tmueller@thmu.de>
To: Brian Buchanan <bwb@holo.org>
Message-Id: <20031010185026.1d238ef5.tmueller@thmu.de>
In-Reply-To: <20031010082316.I78790-100000@thought.holo.org>
References: <20031010082316.I78790-100000@thought.holo.org>
X-Mailer: Sylpheed version 0.9.6claws (GTK+ 1.2.10; i386-portbld-freebsd5.1)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
cc: current@freebsd.org
Subject: Re: ata broken on Thinkpad A22m
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Oct 2003 16:52:20 -0000
X-List-Received-Date: Fri, 10 Oct 2003 16:52:20 -0000

On Fri, 10 Oct 2003 08:37:41 -0700 (PDT) Brian Buchanan wrote:
> After updating to yesterday's -CURRENT, my IBM Thinkpad A22m stoped
> booting.  It hangs at:
> 
> GEOM: create disk ad0 dp=0xc3ded670
> ad0: 38154MB <IC25N040ATCS04-0> [77520/16/63] at ata0-master UDMA33
> ata1: resetting devices ..
> done
> 

I had the same problem on my HP XT6050 laptop. This patch solved the problem
for me.

--- ata-queue.c.1.7	Tue Oct  7 16:38:46 2003
+++ ata-queue.c	Fri Oct 10 09:28:56 2003
@@ -316,7 +316,7 @@
 {
     /* clear timeout etc */
     request->timeout_handle.callout = NULL;
-#if 0
+
     /* call interrupt to try finish up the command */
     request->device->channel->hw.interrupt(request->device->channel);
 
@@ -327,7 +327,6 @@
 		       ata_cmd2str(request));
 	return;
     }
-#endif
 
     /* if this was a DMA request stop the engine to be on the safe side */
     if (request->flags & ATA_R_DMA) {

-- 
Thomas Mueller                  tmueller@thmu.de