From owner-cvs-all@FreeBSD.ORG Wed Dec 20 03:16:54 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A2E2216A407 for ; Wed, 20 Dec 2006 03:16:54 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.190]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD22243C9F for ; Wed, 20 Dec 2006 03:16:51 +0000 (GMT) (envelope-from asmrookie@gmail.com) Received: by nf-out-0910.google.com with SMTP id x37so2339366nfc for ; Tue, 19 Dec 2006 19:16:50 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=J18SAzkScDdsw18e+uZfVyoEVr/ThIqKK6M+VtLGMfknSgp0mEz5GFBK7t2f3ii1oNnbCbWwJt1UmGUVnWnxQEF6bpl3wJt8PHfznHNz2K3GbC2bbWZbcVafpNii+wsV70uiD2/H9xZvuS0iJ9cjWgYXG610FzfBeXyLGsVSFos= Received: by 10.82.113.6 with SMTP id l6mr1337378buc.1166583026951; Tue, 19 Dec 2006 18:50:26 -0800 (PST) Received: by 10.82.178.4 with HTTP; Tue, 19 Dec 2006 18:50:21 -0800 (PST) Message-ID: <3bbf2fe10612191850y3a546fcew486575385b1400df@mail.gmail.com> Date: Wed, 20 Dec 2006 03:50:21 +0100 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Martin Blapp" In-Reply-To: <200612192234.kBJMYYo0055529@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200612192234.kBJMYYo0055529@repoman.freebsd.org> X-Google-Sender-Auth: 7e809033a2ffde4c Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern tty.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2006 03:16:54 -0000 2006/12/19, Martin Blapp : > mbr 2006-12-19 22:34:33 UTC > > FreeBSD src repository > > Modified files: > sys/kern tty.c > Log: > Giant might have been temporarily dropped while waiting for proctree_lock, allowing for an > intervening tty_close() that cleared tp->t_session. Since proctree_lock is a sx lock which uses 2 condition variables, they alredy drop Giant (DROP_GIANT()) before sleeping. Are you secure it is the right thing to do here? Attilio -- Peace can only be achieved by understanding - A. Einstein