From owner-svn-src-all@freebsd.org Mon Mar 6 19:17:22 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F4B6CFCDB6; Mon, 6 Mar 2017 19:17:22 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6EEB01868; Mon, 6 Mar 2017 19:17:22 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 8B894592D; Mon, 6 Mar 2017 19:17:21 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 95AA031EBA; Mon, 6 Mar 2017 19:17:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 19R0nl5ZTiOf; Mon, 6 Mar 2017 19:17:08 +0000 (UTC) Subject: Re: svn commit: r314709 - head DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com B951931EB5 To: rgrimes@freebsd.org, Ian Lepore References: <201703061915.v26JFSSd089794@pdx.rh.CN85.dnsmgr.net> Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Bryan Drewery Organization: FreeBSD Message-ID: Date: Mon, 6 Mar 2017 11:17:07 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <201703061915.v26JFSSd089794@pdx.rh.CN85.dnsmgr.net> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eBTHG7WMUKV8KGAgUkc5fsvbMHjriaW8F" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 19:17:22 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eBTHG7WMUKV8KGAgUkc5fsvbMHjriaW8F Content-Type: multipart/mixed; boundary="LsvwnNPtI9HNt0xmpWtGWuP3c9rPJfW5M"; protected-headers="v1" From: Bryan Drewery To: rgrimes@freebsd.org, Ian Lepore Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-ID: Subject: Re: svn commit: r314709 - head References: <201703061915.v26JFSSd089794@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201703061915.v26JFSSd089794@pdx.rh.CN85.dnsmgr.net> --LsvwnNPtI9HNt0xmpWtGWuP3c9rPJfW5M Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/6/17 11:15 AM, Rodney W. Grimes wrote: > [ Charset ISO-8859-1 unsupported, converting... ] >> On Mon, 2017-03-06 at 10:32 -0800, Rodney W. Grimes wrote: >>> [ Charset ISO-8859-1 unsupported, converting... ] >>>> >>>> On Sun, 2017-03-05 at 19:12 -0800, Bryan Drewery wrote: >>>>> >>>>> On 3/5/17 3:41 PM, Warner Losh wrote: >>>>>> >>>>>> >>>>>> On Sun, Mar 5, 2017 at 2:16 PM, Bryan Drewery >>>>> .org >>>>>>> >>>>>>> wrote: >>>>>>> >>>>>>> Author: bdrewery >>>>>>> Date: Sun Mar??5 21:16:50 2017 >>>>>>> New Revision: 314709 >>>>>>> URL: https://svnweb.freebsd.org/changeset/base/314709 >>>>>>> >>>>>>> Log: >>>>>>> ? Fix bootstrapping mtree after r313404 for older systems. >>>>>>> >>>>>>> ? r313404 made libnetbsd require sha384.h from libmd.??Libmd >>>>>>> added it in >>>>>>> ? r292782.??Update BOOTSTRAPPING to account for this. >>>>>>> >>>>>>> ? Reported by:??bde >>>>>>> ? Reviewed by:??ngie >>>>>>> >>>>>>> Modified: >>>>>>> ? head/Makefile.inc1 >>>>>>> >>>>>>> Modified: head/Makefile.inc1 >>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>> =3D=3D=3D=3D >>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>> --- head/Makefile.inc1??Sun Mar??5 19:56:20 >>>>>>> 2017????????(r314708) >>>>>>> +++ head/Makefile.inc1??Sun Mar??5 21:16:50 >>>>>>> 2017????????(r314709) >>>>>>> @@ -1618,10 +1618,12 @@ ${_bt}-usr.bin/m4: ${_bt}- >>>>>>> lib/libopenbsd >>>>>>> ?${_bt}-usr.bin/lex: ${_bt}-usr.bin/m4 >>>>>>> ?.endif >>>>>>> >>>>>>> -.if ${BOOTSTRAPPING} < 1000026 >>>>>>> -_nmtree=3D???????lib/libnetbsd \ >>>>>> I've been trying to document the bootstrapping stuff inline >>>>>> like >>>>>> >>>>>> # r313404 made libnetbsd require libmd >>>>> Definitely.??I forgot about that.??I think my change is >>>>> incomplete >>>>> and >>>>> need to chase down a 2nd failure report.??I'll add the comment >>>>> once >>>>> that >>>>> is figured out. >>>>> >>>> I tracked this down to the fact that the prototype >>>> >>>> ? char * MD5FileChunk(const char *, char *, off_t, off_t); >>>> >>>> does not exist in /usr/include/sys/md5.h on older systems. ?I don't >>>> see >>>> any straightforward way to declare that a header file from the >>>> /usr/include hierarchy is a bootstrap item that needs a newer >>>> version >>>> from the source tree being compiled. ?It looks like such a header >>>> would >>>> have to go into the obj/.../tmp/legacy/usr/include to get used in >>>> the >>>> boostrap compile, I just don't see how you get a file installed >>>> there >>>> early enough in bootstrap. >>> One way around this is to use the old concept of /usr/include >>> symlinks >>> into the src tree, not sure if you can still do that or not, but >>> something like >>> (cd /usr/src/include; make install SHARED=3Dsymlinks) >>> >>> A bootstrapping regresssion test I use to run was to rm -r >>> /usr/include/* >>> before a buildworld run, that would find these issues so they could >>> be fixed before they become forgotten. >>> ? >> >> Making my live 10-stable system's /usr/include have symlinks into a 11= - >> or 12- source tree is just not an option in any way. ?The first >> question would be "which source tree" because I have like a dozen of >> them, not a single one of them rooted at /usr/src (which is an empty >> dir). >=20 > I dont know that the support of CUrrent -2 building -current with > a bootstraping include issue is ever going to be workable. You > could try to build a proper include tree someplace to use, this > can be done with > (cd; usr/src/include; make install DESTDIR=3D/my/new/tree) This > well not touch your /usr/include, but give you a proper include tree, > now the work is to get buildworld to use that include tree. >=20 > If buildworld has degnerated to using stuff out of /usr/include > that also needs to be fixed ASAP. >=20 buildworld using /usr/include is an intended feature to support cross-building and running tools in the build that interface with the current kernel and not the kernel being built. >> >> This can't be the first time in 30+ years that system header files had= >> to participate in the process of bootstrapping early build tools, but = I >> don't see any machinery in Makefile.inc1 for dealing with it. >=20 > Happens often, hence why I had that regression test. But bootstrappin= g > on Current-2 has never been supported and probably never well be suppor= ted. >=20 >=20 >> -- Ian >=20 --=20 Regards, Bryan Drewery --LsvwnNPtI9HNt0xmpWtGWuP3c9rPJfW5M-- --eBTHG7WMUKV8KGAgUkc5fsvbMHjriaW8F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJYvbWzAAoJEDXXcbtuRpfPNyoH/jOFxQFqe1EmZEMYTygjINj6 grKw/35b2rc7q3ac719o0fPycL/xSbA/5Em12ItN2xBZP2qAVALEgDaptRhIl91f WNxwHcbj66fHgTI6IJxdomfvMVjmx1eWDqNAa1NSTOETIYNVk6AX4An/CllA9yV2 1RueJh1Ma71hw5C+8JlpxGdD93edBf3Vt2c6CEXEPeaGfSYM8lDnV4uBMJuGQEqH XJgY03qPaZmUEDH0Q7hsui/dA8R8ZjwRmV7GZt1Xw6FSxaY47XynAgEUAliSr4Ex 5QLIkYfO7dpfM6o7a9zzSeDqAcni5+XF3ZRFkzThJrpELdxvEK18g56NeoEU7FE= =Veaa -----END PGP SIGNATURE----- --eBTHG7WMUKV8KGAgUkc5fsvbMHjriaW8F--