Date: Tue, 4 Apr 2023 20:10:50 +0200 From: Mateusz Guzik <mjguzik@gmail.com> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Martin Matuska <mm@freebsd.org>, Rick Macklem <rick.macklem@gmail.com>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8ee579abe09e - main - zfs: fall back if block_cloning feature is disabled Message-ID: <CAGudoHHe3FJmW_cEddozQScJcwfbdbbfEn=y%2Bm6wwmzmvEMb-w@mail.gmail.com> In-Reply-To: <20230404093418.3041ff23@slippy> References: <202304041145.334Bjx6l035872@gitrepo.freebsd.org> <20230404141717.B976D31C@slippy.cwsent.com> <CAGudoHEvGDUQkYe8LwUXgTZZa%2B6DAFXVtspCX-Mn2egDO2oc_w@mail.gmail.com> <CAM5tNy6sPx4xE%2BcAeeC_RQG_tba_K6Yh-Cni0%2B-WxJ5SXCuO9A@mail.gmail.com> <98c71e6f-5b48-79f3-e7b0-95d674949624@FreeBSD.org> <20230404091844.639cb1c1@slippy> <20230404093418.3041ff23@slippy>
next in thread | previous in thread | raw e-mail | index | archive | help
can you please post a review On 4/4/23, Cy Schubert <Cy.Schubert@cschubert.com> wrote: > The previously posted patch containing the following fixes all > regressions discussed so far: > > - Rick's fix null ap->a_fsizetd NULL pointer derefernce > - Rick's call vn_generic_copy_file_range() when block_cloning is > disabled > - Martin's call vn_generic_copy_file_range() when any other error > resulting in EXDEV > > > -- > Cheers, > Cy Schubert <Cy.Schubert@cschubert.com> > FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org > NTP: <cy@nwtime.org> Web: https://nwtime.org > > e^(i*pi)+1=0 > > > On Tue, 4 Apr 2023 09:18:44 -0700 > Cy Schubert <Cy.Schubert@cschubert.com> wrote: > >> On Tue, 4 Apr 2023 17:30:25 +0200 >> Martin Matuska <mm@FreeBSD.org> wrote: >> >> > So I am now a little bit confused - what is the consensus? :-) >> >> My exmh email client made a mess of that. Let's try this again. >> >> Rick has posted a patch. Your patch should also be incorporated to work >> around other EXDEV errors, but a few lines earlier so it is protected by >> the lock. >> >> There were a couple of typos in Rick's patch (a missing keystroke; >> s/ojset/objset/). >> >> The patch (Rick's null pointer dereference fix, Rick's copy file range >> patch plus your copy file range patch) builds fine on amd64 and i386. >> Installing and testing it now. >> >> A combination of all three patches is attached. It's compile tested but is >> >> currently being installed and will be tested when install is completed. >> > > -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHHe3FJmW_cEddozQScJcwfbdbbfEn=y%2Bm6wwmzmvEMb-w>