From owner-svn-src-all@FreeBSD.ORG Wed Sep 15 11:51:09 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 511511065679; Wed, 15 Sep 2010 11:51:09 +0000 (UTC) (envelope-from lstewart@freebsd.org) Received: from lauren.room52.net (lauren.room52.net [210.50.193.198]) by mx1.freebsd.org (Postfix) with ESMTP id 11CA58FC17; Wed, 15 Sep 2010 11:51:08 +0000 (UTC) Received: from lawrence1.loshell.room52.net (ppp59-167-184-191.static.internode.on.net [59.167.184.191]) by lauren.room52.net (Postfix) with ESMTPSA id F0D057E853; Wed, 15 Sep 2010 21:51:06 +1000 (EST) Message-ID: <4C90B326.4000208@freebsd.org> Date: Wed, 15 Sep 2010 21:51:02 +1000 From: Lawrence Stewart User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-AU; rv:1.9.2.9) Gecko/20100913 Lightning/1.0b2 Thunderbird/3.1.3 MIME-Version: 1.0 To: Andre Oppermann References: <201009151039.o8FAdU4H030416@svn.freebsd.org> In-Reply-To: <201009151039.o8FAdU4H030416@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on lauren.room52.net Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r212653 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2010 11:51:09 -0000 On 09/15/10 20:39, Andre Oppermann wrote: > Author: andre > Date: Wed Sep 15 10:39:30 2010 > New Revision: 212653 > URL: http://svn.freebsd.org/changeset/base/212653 > > Log: > Change the default MSS for IPv4 and IPv6 TCP connections from an > artificial power-of-2 rounded number to their real values specified > in RFC879 and RFC2460. > > From the history and existing comments it appears that the rounded > numbers were intended to be advantageous for the kernel and mbuf > system. However this hasn't been the case at for at least a long > time. The mbuf clusters used in tcp_output() have enough space > to hold the larger real value for the default MSS for both IPv4 and > IPv6. Note that the default MSS is only used when path MTU discovery > is disabled. > > Update and expand related comments. > > Reviewed by: lsteward (including some word-smithing) For the record, I reviewed and fully support the functional changes made by this patch, but explicitly objected to and offered an alternate for the proposed comment wording changes. Andre, given that we had a disagreement about the comment wording, I would have preferred it if you had noted in your commit log that I had raised an objection to or at least not reviewed/endorsed the comment changes. It's not important enough an issue to spend any more time on, but I'm a bit upset to see this committed with an acknowledgement to my review and word-smithing, much of which ended up being ignored (which is fine, but then don't put my name to it). Cheers, Lawrence