Date: Thu, 21 Jul 2022 09:24:57 -0600 From: Warner Losh <imp@bsdimp.com> To: Kyle Evans <kevans@freebsd.org> Cc: Mark Millard <marklmi@yahoo.com>, Glen Barber <gjb@freebsd.org>, Ed Maste <emaste@freebsd.org>, "Rodney W. Grimes" <freebsd-rwg@gndrsh.dnsmgr.net>, dev-commits-src-main@freebsd.org, "Dr. Rolf Jansen" <freebsd-rj@cyclaero.com>, freebsd-arm <freebsd-arm@freebsd.org> Subject: Re: git: 1dfcff294e44 - main - release: increase IMAGE_SIZE for arm, arm64, riscv [odd alignment for SBC images] Message-ID: <CANCZdfq5xK9k6iKMkD1SsHotXci=fvJ6P339_%2BG4QhyiVT8=-g@mail.gmail.com> In-Reply-To: <CACNAnaEkFC1jvno--DqLJ7RRcQZ3jZzEm2YTm%2BU2boC4pC8t3g@mail.gmail.com> References: <16906DFD-286B-4D59-9438-CA9CD9026C55@yahoo.com> <202207171708.26HH81bA062303@gndrsh.dnsmgr.net> <CAPyFy2D1aBe8h4kq=RqCR2tkEiEXh_pHNEqaAnW7tk9-HxCmBQ@mail.gmail.com> <20220719204245.GL30607@FreeBSD.org> <CANCZdfoABLggPQgDeCZ5FzYCf8243kvr-p8Bj5_JGNnEszGHBw@mail.gmail.com> <D630043D-6EAC-4216-A046-910DB64F8B4A@yahoo.com> <CACNAnaEkFC1jvno--DqLJ7RRcQZ3jZzEm2YTm%2BU2boC4pC8t3g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000ab6c0105e4525284 Content-Type: text/plain; charset="UTF-8" On Thu, Jul 21, 2022 at 8:55 AM Kyle Evans <kevans@freebsd.org> wrote: > On Wed, Jul 20, 2022 at 10:08 AM Mark Millard <marklmi@yahoo.com> wrote: > > > > On 2022-Jul-19, at 15:45, Warner Losh <imp@bsdimp.com> wrote: > > > > > On Tue, Jul 19, 2022, 2:42 PM Glen Barber <gjb@freebsd.org> wrote: > > >>> . . . > > >> > > >> My concern with this is kern.geom.part.mbr.enforce_chs is always '1' > on > > >> the builders, which effectively means all arm builds will fail every > > >> time. I think we need to get to the actual root of the problem here, > > >> versus applying band-aids to a shark bite. > > > > > > I think this is the actual problem. While such pedantry can be useful > for ancient picky BIOSes, these days only the LBA fields of the MBR are > used. And the fake BIOS geometry is crazy weird. We can likely tweak it to > be more friendly. > > > > > > Why is it == 1 on the builder? If people want things aligned gpart has > an option for years iirc to do that. And we want that off for the builds. > > > > Would it seem appropriate to use a week (this week?) to do all > > the snapshot builds with the builders all set to have > > kern.geom.part.mbr.enforce_chs=0 and see what breaks, if anything? > > (Sort of a snapshot exp run.) > > > > https://svnweb.freebsd.org/base?view=revision&revision=332731 says: > > Note: In addition to this merge, kern.geom.part.mbr.enforce_chs has > been enabled on the build machine to mitigate against the issue in > the PR referenced. > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226536 > ("glabel/partition mixup on sdcard images") > Having read through all that, I think it's safe to disable it again. We changed the build process to avoid the original bug, so no longer need the rounding to prevent the situation from happening. There are no old branches or legacy reasons to keep it enabled unless there's another side effect of it that I'm not seeing... Warner --000000000000ab6c0105e4525284 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jul 21, 2022 at 8:55 AM Kyle = Evans <<a href=3D"mailto:kevans@freebsd.org">kevans@freebsd.org</a>> = wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0= px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, J= ul 20, 2022 at 10:08 AM Mark Millard <<a href=3D"mailto:marklmi@yahoo.co= m" target=3D"_blank">marklmi@yahoo.com</a>> wrote:<br> ><br> > On 2022-Jul-19, at 15:45, Warner Losh <<a href=3D"mailto:imp@bsdimp= .com" target=3D"_blank">imp@bsdimp.com</a>> wrote:<br> ><br> > > On Tue, Jul 19, 2022, 2:42 PM Glen Barber <<a href=3D"mailto:g= jb@freebsd.org" target=3D"_blank">gjb@freebsd.org</a>> wrote:<br> > >>> . . .<br> > >><br> > >> My concern with this is kern.geom.part.mbr.enforce_chs is alw= ays '1' on<br> > >> the builders, which effectively means all arm builds will fai= l every<br> > >> time.=C2=A0 I think we need to get to the actual root of the = problem here,<br> > >> versus applying band-aids to a shark bite.<br> > ><br> > > I think this is the actual problem. While such pedantry can be us= eful for ancient picky BIOSes, these days only the LBA fields of the MBR ar= e used. And the fake BIOS geometry is crazy weird. We can likely tweak it t= o be more friendly.<br> > ><br> > > Why is it =3D=3D 1 on the builder? If people want things aligned = gpart has an option for years iirc to do that. And we want that off for the= builds.<br> ><br> > Would it seem appropriate to use a week (this week?) to do all<br> > the snapshot builds with the builders all set to have<br> > kern.geom.part.mbr.enforce_chs=3D0 and see what breaks, if anything?<b= r> > (Sort of a snapshot exp run.)<br> ><br> <br> <a href=3D"https://svnweb.freebsd.org/base?view=3Drevision&revision=3D3= 32731" rel=3D"noreferrer" target=3D"_blank">https://svnweb.freebsd.org/base= ?view=3Drevision&revision=3D332731</a> says:<br> <br> Note: In addition to this merge, kern.geom.part.mbr.enforce_chs has<br> been enabled on the build machine to mitigate against the issue in<br> the PR referenced.<br> <br> <a href=3D"https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226536" rel= =3D"noreferrer" target=3D"_blank">https://bugs.freebsd.org/bugzilla/show_bu= g.cgi?id=3D226536</a><br> ("glabel/partition mixup on sdcard images")<br></blockquote><div>= <br></div><div>Having read through all that, I think it's safe to disab= le it again. We changed the build process</div><div>to avoid the original b= ug, so no longer need the rounding to prevent the situation from happening.= </div><div>There are no old branches or legacy reasons to keep it enabled u= nless there's another side effect</div><div>of it that I'm not seei= ng...</div><div><br></div><div>Warner</div></div></div> --000000000000ab6c0105e4525284--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfq5xK9k6iKMkD1SsHotXci=fvJ6P339_%2BG4QhyiVT8=-g>