From owner-freebsd-current@FreeBSD.ORG Sun May 7 04:36:45 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B6D4016A400 for ; Sun, 7 May 2006 04:36:45 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D79C43D45 for ; Sun, 7 May 2006 04:36:45 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id k474agww003154 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 6 May 2006 21:36:43 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <445D795A.6000301@errno.com> Date: Sat, 06 May 2006 21:36:42 -0700 From: Sam Leffler User-Agent: Thunderbird 1.5 (X11/20060210) MIME-Version: 1.0 To: Eric Anderson References: <445D3C94.10102@errno.com> <445D5D42.9040107@centtech.com> In-Reply-To: <445D5D42.9040107@centtech.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: current@freebsd.org Subject: Re: CFT: new ath hal (take 2) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 May 2006 04:36:46 -0000 Eric Anderson wrote: > Sam Leffler wrote: >> A new test snapshot is available at: >> >> http://people.freebsd.org/~sam/ath_hal-20060506.tgz >> >> This is 0.9.17.0 and is known to work on sparc (tested) and may well >> work on alpha (untested but likely the same issue that broke sparc). >> >> This code should be a drop-in replacement for what's in cvs in HEAD >> but be sure to rebuild both the driver and rate control module as >> there are ABI changes. Note that to use this hal with RELENG_6 or >> other branches other than HEAD you must have rev 1.143 of if_ath.c. >> To build a sparc module you must have rev 1.5 of >> modules/ath_hal/Makefile and rev 1.539 of conf/options. >> >> Please test and report regressions. > > On 6.1-RC2, I get compile errors: > 6.1-RC FreeBSD 6.1-RC #15: Fri May 5 08:29:44 CDT 2006 > if_ath.c: __FBSDID("$FreeBSD: src/sys/dev/ath/if_ath.c,v 1.94.2.18 > 2006/05/02 17:06:35 sam Exp $"); > > [..snip..] > ===> ath (all) > cc -O2 -pipe -march=pentiumpro -fno-strict-aliasing -Werror -D_KERNEL > -DKLD_MODULE -nostdinc -I- -I. > -I/usr/src/sys/modules/ath/../../contrib/dev/ath/freebsd > -I/usr/src/sys/modules/ath/../../contrib/dev/ath > -DHAVE_KERNEL_OPTION_HEADERS -include > /usr/obj/usr/src/sys/NEUTRINO/opt_global.h -I. -I@ -I@/contrib/altq > -I@/../include -finline-limit=8000 -fno-common -g > -I/usr/obj/usr/src/sys/NEUTRINO -mno-align-long-strings > -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 > -ffreestanding -Wall -Wredundant-decls -Wnested-externs > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline > -Wcast-qual -fformat-extensions -std=c99 -c > /usr/src/sys/modules/ath/../../dev/ath/if_ath.c > /usr/src/sys/modules/ath/../../dev/ath/if_ath.c: In function `ath_attach': > /usr/src/sys/modules/ath/../../dev/ath/if_ath.c:296: warning: passing > arg 3 of `ath_hal_attach' makes pointer from integer without a cast > /usr/src/sys/modules/ath/../../dev/ath/if_ath.c:296: warning: passing > arg 4 of `ath_hal_attach' makes pointer from integer without a cast > *** Error code 1 > > Stop in /usr/src/sys/modules/ath. > *** Error code 1 > > Stop in /usr/src/sys/modules. > *** Error code 1 > > Stop in /usr/obj/usr/src/sys/NEUTRINO. > *** Error code 1 > > Stop in /usr/src. > *** Error code 1 > > Stop in /usr/src. > > > > > Like I said: Note that to use this hal with RELENG_6 or >> other branches other than HEAD you must have rev 1.143 of if_ath.c.