From owner-freebsd-current@FreeBSD.ORG Tue Jun 8 17:57:27 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5910D16A4CE for ; Tue, 8 Jun 2004 17:57:27 +0000 (GMT) Received: from creme-brulee.marcuscom.com (rrcs-midsouth-24-172-16-118.biz.rr.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id E00C243D49 for ; Tue, 8 Jun 2004 17:57:26 +0000 (GMT) (envelope-from marcus@marcuscom.com) Received: from [192.168.1.4] (shumai.marcuscom.com [192.168.1.4]) i58HuMZm003561; Tue, 8 Jun 2004 13:56:22 -0400 (EDT) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Dan Nelson In-Reply-To: <20040608154510.GB89198@dan.emsphone.com> References: <1086663455.1258.79.camel@server.mcneil.com> <20040608044844.GA89198@dan.emsphone.com> <20040608072706.GA82243@xor.obsecurity.org> <20040608154510.GB89198@dan.emsphone.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-FnZVoL0BYwSU0eYirIzC" Organization: MarcusCom, Inc. Message-Id: <1086717435.68846.9.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Tue, 08 Jun 2004 13:57:16 -0400 X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on creme-brulee.marcuscom.com cc: freebsd-amd64@freebsd.org cc: freebsd-gnome@freebsd.org cc: freebsd-threads@freebsd.org cc: freebsd-current@freebsd.org cc: Kris Kennaway cc: Sean McNeil Subject: Re: weak implementation of threads has problems - kse fix attached X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 17:57:27 -0000 --=-FnZVoL0BYwSU0eYirIzC Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2004-06-08 at 11:45, Dan Nelson wrote: > In the last episode (Jun 08), Kris Kennaway said: > > On Mon, Jun 07, 2004 at 11:48:45PM -0500, Dan Nelson wrote: > > > In the last episode (Jun 08), Daniel Eischen said: > > > > No, I don't want to litter all our thread libraries with strong > > > > references. As I've said before, build your shared libraries > > > > correctly so they don't bring in the threads library. > > >=20 > > > A good addition to bsd.port.mk, right next to the "possible network > > > server" etc checks, might be to run ldd on all installed shared > > > libraries and print a warning if any threads libraries show up. Ther= e > > > are a huge number of ports that install shlibs linked to libpthreads. > >=20 > > Some of these are probably correct, in that the library started using > > libpthreads internally and there are a large number of clients that > > would otherwise need to be changed to link to that library. >=20 > I don't think you can have it both ways, though. The rule is either > "pthreads-using shared libraries should pull in a pthreads lib > themselves" or "programs wanting to link to pthreads-using shared > libraries should link with a pthreads lib". >=20 > Attached are patches to add this check to the security-check target.=20 > Ideally they would be checked separately or flagged as something other > than security problems, but that would require copying > security-check.awk and a larger diff.. If we switched PTHREAD_LIBS to -pthread, we wouldn't need this. Shared objects would not have a link to libpthread, and shared objects that really referenced pthread symbols would still require executables to be linked to PTHREAD_LIBS (i.e. how it works on 4.X). Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-FnZVoL0BYwSU0eYirIzC Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAxf37b2iPiv4Uz4cRAmjEAJ9eZKBGVjPP0j7K+IPemwL49iNo7gCfVmGb 7LWrJiKxUkm7wAmN+o44+A0= =fnCz -----END PGP SIGNATURE----- --=-FnZVoL0BYwSU0eYirIzC--